webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc - Issue 1221943002: Improve probing by ignoring small packets which otherwise break the mechanism.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

Issue 1221943002: Improve probing by ignoring small packets which otherwise break the mechanism. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix test. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/pacing/bitrate_prober.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

index e83ac812e31498d9cf9da6bd7472fd95f045c1d1..c5faf1617f9631e29c43d9ef6348d9e865f970e5 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

@@ -16,6 +16,7 @@

#include "webrtc/base/scoped_ptr.h"

#include "webrtc/base/thread_annotations.h"

#include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h"

+#include "webrtc/modules/pacing/bitrate_prober.h"

#include "webrtc/system_wrappers/interface/clock.h"

#include "webrtc/system_wrappers/interface/critical_section_wrapper.h"

#include "webrtc/system_wrappers/interface/logging.h"

@@ -268,7 +269,10 @@ void RemoteBitrateEstimatorAbsSendTime::IncomingPacketInfo(

uint32_t ts_delta = 0;

int64_t t_delta = 0;

int size_delta = 0;

- // For now only try to detect probes while we don't have a valid estimate.

+ // For now only try to detect probes while we don't have a valid estimate, and

+ // make sure the packet was paced. We currently assume that only packets

+ // larger than 200 bytes are paced by the sender.

+ was_paced = was_paced && payload_size > BitrateProber::kMinProbePacketSize;

if (was_paced &&

(!remote_rate_.ValidEstimate() ||

now_ms - first_packet_time_ms_ < kInitialProbingIntervalMs)) {