Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc

Issue 1220753003: Prevent OOB reads in FEC packets without complete RED headers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback + updated comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/fec_receiver_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 0x29, 394 0x29,
395 0x12, 395 0x12,
396 0x2a, 396 0x2a,
397 0x98, 397 0x98,
398 0xe0, 398 0xe0,
399 0x29}; 399 0x29};
400 400
401 SurvivesMaliciousPacket(kTruncatedPacket, sizeof(kTruncatedPacket), 100); 401 SurvivesMaliciousPacket(kTruncatedPacket, sizeof(kTruncatedPacket), 100);
402 } 402 }
403 403
404 TEST_F(ReceiverFecTest, TruncatedPacketWithFBitSetEndingAfterFirstRedHeader) {
405 const uint8_t kPacket[] = {0xa9,
406 0x27,
407 0x3a,
408 0x83,
409 0x27,
410 0x3a,
411 0x3a,
412 0xf3,
413 0x67,
414 0xbe,
415 0x2a,
416 0xa9,
417 0x27,
418 0x54,
419 0x3a,
420 0x3a,
421 0x2a,
422 0x67,
423 0x3a,
424 0xf3,
425 0x67,
426 0xbe,
427 0x2a,
428 0x27,
429 0xe6,
430 0xf6,
431 0x03,
432 0x3e,
433 0x29,
434 0x27,
435 0x21,
436 0x27,
437 0x2a,
438 0x29,
439 0x21,
440 0x4b,
441 0x29,
442 0x3a,
443 0x28,
444 0x29,
445 0xbf,
446 0x29,
447 0x2a,
448 0x26,
449 0x29,
450 0xae,
451 0x27,
452 0xa6,
453 0xf6,
454 0x00,
455 0x03,
456 0x3e};
457 SurvivesMaliciousPacket(kPacket, sizeof(kPacket), 100);
458 }
459
460 TEST_F(ReceiverFecTest, TruncatedPacketWithoutDataPastFirstBlock) {
461 const uint8_t kPacket[] = {0x82,
462 0x38,
463 0x92,
464 0x38,
465 0x92,
466 0x38,
467 0xde,
468 0x2a,
469 0x11,
470 0xc8,
471 0xa3,
472 0xc4,
473 0x82,
474 0x38,
475 0x2a,
476 0x21,
477 0x2a,
478 0x28,
479 0x92,
480 0x38,
481 0x92,
482 0x00,
483 0x00,
484 0x0a,
485 0x3a,
486 0xc8,
487 0xa3,
488 0x3a,
489 0x27,
490 0xc4,
491 0x2a,
492 0x21,
493 0x2a,
494 0x28};
495 SurvivesMaliciousPacket(kPacket, sizeof(kPacket), 100);
496 }
497
404 } // namespace webrtc 498 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/fec_receiver_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698