Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1220193002: Add test for dropping repeated NTP timestamps. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add test for dropping repeated NTP timestamps. Regression test for enforcing that frames with repeated or old NTP timestamps are dropped. BUG=chromium:480953, webrtc:4615 R=stefan@webrtc.org Committed: https://crrev.com/db0cf7624e8b7782e8b0864f9e01925ecdc3027d Cr-Commit-Position: refs/heads/master@{#9533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M webrtc/video/video_capture_input_unittest.cc View 3 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
pbos-webrtc
PTAL, the bug said to do it all the way to the encoder, but I ...
5 years, 5 months ago (2015-07-02 09:43:00 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220193002/1
5 years, 5 months ago (2015-07-02 09:43:18 UTC) #3
stefan-webrtc
lgtm
5 years, 5 months ago (2015-07-02 09:45:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1220193002/1
5 years, 5 months ago (2015-07-02 11:00:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 11:14:51 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 11:15:02 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db0cf7624e8b7782e8b0864f9e01925ecdc3027d
Cr-Commit-Position: refs/heads/master@{#9533}

Powered by Google App Engine
This is Rietveld 408576698