Chromium Code Reviews

Issue 1219333002: Use "UDP/TLS/RTP/SAVPF" profile in offer when DTLS-SRTP is used. (Closed)

Created:
5 years, 5 months ago by Taylor Brandstetter
Modified:
5 years, 5 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use "UDP/TLS/RTP/SAVPF" profile in offer when DTLS-SRTP is used. Tested that this doesn't break compatibility with Firefox or older versions of Chrome, no matter which side generates the initial offer. BUG=webrtc:2796 Committed: https://crrev.com/f39382943449b7e44ac563e05a14203534591acf Cr-Commit-Position: refs/heads/master@{#9589}

Patch Set 1 #

Patch Set 2 : Fixing some unit tests, and changing the profile to "RTP/SAVPF" when both DTLS-SRTP *and* SDES are … #

Patch Set 3 : Fixing some unit tests to account for new behavior #

Unified diffs Side-by-side diffs Stats (+12 lines, -7 lines)
M talk/app/webrtc/webrtcsession_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments
M talk/session/media/mediasession.cc View 3 chunks +7 lines, -5 lines 0 comments

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
5 years, 5 months ago (2015-07-02 22:21:30 UTC) #2
pthatcher1
lgtm
5 years, 5 months ago (2015-07-06 22:06:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219333002/40001
5 years, 5 months ago (2015-07-15 17:59:11 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-15 19:20:58 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 19:21:05 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f39382943449b7e44ac563e05a14203534591acf
Cr-Commit-Position: refs/heads/master@{#9589}

Powered by Google App Engine