Issue 1218093002: Move early-return in TimeToSendPadding.

Issue 1218093002: Move early-return in TimeToSendPadding. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc

Modified:
5 years, 5 months ago

Reviewers:
stefan-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Move early-return in TimeToSendPadding. Prevents taking send_critsect_ for checking sending status when not actually intending to send padding. BUG= R=stefan@webrtc.org Committed: https://crrev.com/545727ecce444320328b825d65b287e844dca7cb Cr-Commit-Position: refs/heads/master@{#9526}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webrtc/modules/rtp_rtcp/source/rtp_sender.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 10 (3 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218093002/1

5 years, 5 months ago (2015-06-30 15:45:34 UTC) #2

pbos-webrtc

Hardest CL ever, PTAL. Impact not guesstimated, not sure if we actually call this with ...

5 years, 5 months ago (2015-06-30 15:45:51 UTC) #3

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 5 months ago (2015-06-30 17:42:23 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218093002/1

5 years, 5 months ago (2015-07-01 13:30:06 UTC) #8

commit-bot: I haz the power

5 years, 5 months ago (2015-07-01 13:31:25 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/545727ecce444320328b825d65b287e844dca7cb
Cr-Commit-Position: refs/heads/master@{#9526}