Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc

Issue 1218023003: Prevent OOB read on truncated H264 headers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: additional StapANalu overflows Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 527 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 EXPECT_EQ(kIdr, payload.type.Video.codecHeader.H264.nalu_type); 538 EXPECT_EQ(kIdr, payload.type.Video.codecHeader.H264.nalu_type);
539 } 539 }
540 540
541 TEST_F(RtpDepacketizerH264Test, TestEmptyPayload) { 541 TEST_F(RtpDepacketizerH264Test, TestEmptyPayload) {
542 // Using a wild pointer to crash on accesses from inside the depacketizer. 542 // Using a wild pointer to crash on accesses from inside the depacketizer.
543 uint8_t* garbage_ptr = reinterpret_cast<uint8_t*>(0x4711); 543 uint8_t* garbage_ptr = reinterpret_cast<uint8_t*>(0x4711);
544 RtpDepacketizer::ParsedPayload payload; 544 RtpDepacketizer::ParsedPayload payload;
545 EXPECT_FALSE(depacketizer_->Parse(&payload, garbage_ptr, 0)); 545 EXPECT_FALSE(depacketizer_->Parse(&payload, garbage_ptr, 0));
546 } 546 }
547 547
548 TEST_F(RtpDepacketizerH264Test, TestTruncatedFuaNalu) {
549 const uint8_t kPayload[] = {0x9c};
550 RtpDepacketizer::ParsedPayload payload;
551 EXPECT_FALSE(depacketizer_->Parse(&payload, kPayload, sizeof(kPayload)));
552 }
553
554 TEST_F(RtpDepacketizerH264Test, TestTruncatedSingleStapANalu) {
555 const uint8_t kPayload[] = {0xd8, 0x27};
556 RtpDepacketizer::ParsedPayload payload;
557 EXPECT_FALSE(depacketizer_->Parse(&payload, kPayload, sizeof(kPayload)));
558 }
559
560 TEST_F(RtpDepacketizerH264Test, TestTruncationJustAfterSingleStapANalu) {
561 const uint8_t kPayload[] = {0x38, 0x27, 0x27};
562 RtpDepacketizer::ParsedPayload payload;
563 EXPECT_FALSE(depacketizer_->Parse(&payload, kPayload, sizeof(kPayload)));
564 }
565
548 } // namespace webrtc 566 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698