Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1218013002: Prevent OOB reads for zero-length H264 payloads. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Prevent OOB reads for zero-length H264 payloads. Also fixes zero-length OOB reads for generic packetization. BUG=webrtc:4771 R=stefan@webrtc.org Committed: https://crrev.com/7ada923a94de3cd95142b3052996f9b38e134f39 Cr-Commit-Position: refs/heads/master@{#9521}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_format_h264.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc View 1 chunk +8 lines, -0 lines 2 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_format_video_generic.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
stefan-webrtc
https://codereview.webrtc.org/1218013002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc File webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc (right): https://codereview.webrtc.org/1218013002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc#newcode541 webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:541: TEST_F(RtpDepacketizerH264Test, TestEmptyPayload) { Seems like we may want to ...
5 years, 5 months ago (2015-06-30 10:20:03 UTC) #1
pbos-webrtc
https://codereview.webrtc.org/1218013002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc File webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc (right): https://codereview.webrtc.org/1218013002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc#newcode541 webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:541: TEST_F(RtpDepacketizerH264Test, TestEmptyPayload) { On 2015/06/30 10:20:03, stefan-webrtc (holmer) wrote: ...
5 years, 5 months ago (2015-06-30 11:22:05 UTC) #2
stefan-webrtc
lgtm
5 years, 5 months ago (2015-06-30 11:23:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218013002/1
5 years, 5 months ago (2015-06-30 11:23:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 12:09:44 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 12:09:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ada923a94de3cd95142b3052996f9b38e134f39
Cr-Commit-Position: refs/heads/master@{#9521}

Powered by Google App Engine
This is Rietveld 408576698