|
|
Created:
5 years, 5 months ago by tkchin_webrtc Modified:
5 years, 5 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd tkchin to video_coding OWNERS.
BUG=
R=stefan@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/d830aeafe943b498fd0db51f949dc183be3b4e4f
Patch Set 1 #Patch Set 2 : CR comemnts #Messages
Total messages: 20 (7 generated)
tkchin@webrtc.org changed reviewers: + stefan@webrtc.org
I should probably be OWNER for at least the iOS h264 things.
On 2015/06/29 22:48:04, tkchin_webrtc wrote: > I should probably be OWNER for at least the iOS h264 things. Do you feel you have good knowledge of how the rest of the video_coding module works (e.g., jitter buffer etc?). Maybe it would make sense to limit the ownership to video_coding/codecs for now?
I want OWNERS for the gyp file, which lives in video_coding/. But no I don't want owners for the rest of the video_coding module. I'll remove it, but you are signing up for every review that touches the build config now :)
On 2015/06/30 18:21:19, tkchin_webrtc wrote: > I want OWNERS for the gyp file, which lives in video_coding/. But no I don't > want owners for the rest of the video_coding module. > I'll remove it, but you are signing up for every review that touches the build > config now :) Hehe... Feel free to add yourself to the video_coding/ as well, and add a comment about the gyp file maybe? Otherwise I'm ok with reviewing that piece as well, but it might be good to reduce the RTTs. :)
On 2015/06/30 18:24:22, stefan-webrtc (holmer) wrote: > On 2015/06/30 18:21:19, tkchin_webrtc wrote: > > I want OWNERS for the gyp file, which lives in video_coding/. But no I don't > > want owners for the rest of the video_coding module. > > I'll remove it, but you are signing up for every review that touches the build > > config now :) > > Hehe... Feel free to add yourself to the video_coding/ as well, and add a > comment about the gyp file maybe? > > Otherwise I'm ok with reviewing that piece as well, but it might be good to > reduce the RTTs. :) lgtm
On 2015/06/30 18:26:30, stefan-webrtc (holmer) wrote: > On 2015/06/30 18:24:22, stefan-webrtc (holmer) wrote: > > On 2015/06/30 18:21:19, tkchin_webrtc wrote: > > > I want OWNERS for the gyp file, which lives in video_coding/. But no I don't > > > want owners for the rest of the video_coding module. > > > I'll remove it, but you are signing up for every review that touches the > build > > > config now :) > > > > Hehe... Feel free to add yourself to the video_coding/ as well, and add a > > comment about the gyp file maybe? > > > > Otherwise I'm ok with reviewing that piece as well, but it might be good to > > reduce the RTTs. :) > > lgtm Actually modules/OWNERS has these so I think we're good: per-file *.gyp=* per-file *.gypi=*
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217853006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217853006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217853006/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as d830aeafe943b498fd0db51f949dc183be3b4e4f (presubmit successful). |