Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: webrtc/p2p/base/p2ptransportchannel_unittest.cc

Issue 1217463004: Fix active tcp port to 9 (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: add comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/p2p/base/tcpport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/p2ptransportchannel_unittest.cc
diff --git a/webrtc/p2p/base/p2ptransportchannel_unittest.cc b/webrtc/p2p/base/p2ptransportchannel_unittest.cc
index 8ec6474a2d9567101942467a5985ff0029c1c3e9..cf7e6b5916ae0d7b162a8d78fcbae59f1a6e6793 100644
--- a/webrtc/p2p/base/p2ptransportchannel_unittest.cc
+++ b/webrtc/p2p/base/p2ptransportchannel_unittest.cc
@@ -639,6 +639,14 @@ class P2PTransportChannelTestBase : public testing::Test,
if (force_relay_ && c.type() != cricket::RELAY_PORT_TYPE)
return;
+ if (c.protocol() == cricket::TCP_PROTOCOL_NAME) {
juberti 2015/11/14 01:09:28 I think this would be best in the TestTcp* tests b
+ if (c.tcptype() == cricket::TCPTYPE_ACTIVE_STR) {
+ EXPECT_EQ(c.address().port(), cricket::DISCARD_PORT);
+ } else {
+ EXPECT_NE(c.address().port(), cricket::DISCARD_PORT);
+ }
+ }
+
if (GetEndpoint(ch)->save_candidates_) {
GetEndpoint(ch)->saved_candidates_.push_back(new CandidateData(ch, c));
} else {
« no previous file with comments | « no previous file | webrtc/p2p/base/tcpport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698