Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 1216613002: Extend full stack tests with more stats (Closed)

Created:
5 years, 6 months ago by sprang_webrtc
Modified:
5 years, 5 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Formatting #

Total comments: 10

Patch Set 3 : Comment #

Patch Set 4 : Addressed comments #

Patch Set 5 : Cleanup #

Total comments: 8

Patch Set 6 : Addressed comments #

Patch Set 7 : Fixed race, addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -12 lines) Patch
M webrtc/video/full_stack.cc View 1 2 3 4 5 6 12 chunks +73 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
sprang_webrtc
5 years, 6 months ago (2015-06-26 13:47:46 UTC) #2
pbos-webrtc
https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc#newcode170 webrtc/video/full_stack.cc:170: encoded_frame_sizes_[timestamp] += Why do you need a += here ...
5 years, 5 months ago (2015-06-28 18:35:32 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc#newcode170 webrtc/video/full_stack.cc:170: encoded_frame_sizes_[timestamp] += On 2015/06/28 18:35:31, pbos-webrtc wrote: > Why ...
5 years, 5 months ago (2015-07-06 11:19:00 UTC) #4
pbos-webrtc
https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc#newcode170 webrtc/video/full_stack.cc:170: encoded_frame_sizes_[timestamp] += On 2015/07/06 11:19:00, språng wrote: > On ...
5 years, 5 months ago (2015-07-06 11:36:01 UTC) #5
sprang_webrtc
https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1216613002/diff/20001/webrtc/video/full_stack.cc#newcode170 webrtc/video/full_stack.cc:170: encoded_frame_sizes_[timestamp] += On 2015/07/06 11:36:00, pbos-webrtc wrote: > On ...
5 years, 5 months ago (2015-07-17 11:42:07 UTC) #6
pbos-webrtc
lgtm https://codereview.webrtc.org/1216613002/diff/80001/webrtc/video/full_stack.cc File webrtc/video/full_stack.cc (right): https://codereview.webrtc.org/1216613002/diff/80001/webrtc/video/full_stack.cc#newcode304 webrtc/video/full_stack.cc:304: default: Do you need default: here? (Is this ...
5 years, 5 months ago (2015-07-21 20:47:49 UTC) #7
sprang_webrtc
Addressed comments and fixed a race in the test code. Not sure if you wanna ...
5 years, 5 months ago (2015-07-22 12:12:10 UTC) #8
pbos-webrtc
lgtm
5 years, 5 months ago (2015-07-22 12:31:40 UTC) #9
sprang_webrtc
5 years, 5 months ago (2015-07-22 15:18:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
085856cd35c3ec7d5b73d6788465868bbd99ae26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698