Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1216353002: Fix some clang warnings with -Wmissing-braces in WebRTC. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
henrika (OOO until Aug 14), webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix some clang warnings with -Wmissing-braces in WebRTC. Clang warns if there are missing braces around a subobject initializer. The most common idiom that triggers this is: STRUCT s = {0}; if the first field of STRUCT is itself a struct. This can be more simply written as: STRUCT s = {}; which also prevents the warning from firing. Other instances of the warning have been fixed by adding braces where appropriate. BUG=505297 TBR=jiayl@webrtc.org Committed: https://crrev.com/a771bf8ee84f293c166d3e377d852e9705c12725 Cr-Commit-Position: refs/heads/master@{#9529}

Patch Set 1 #

Patch Set 2 : rebase? #

Patch Set 3 : Fix paths, maybe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M webrtc/base/win32.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/desktop_frame_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/system_wrappers/source/clock.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
dcheng
+henrika for base and system_wrappers changes +jiayl for modules/desktop_capture changes
5 years, 5 months ago (2015-07-01 07:38:09 UTC) #2
dcheng
+henrikg, mind taking a look at the base/system_wrappers changes?
5 years, 5 months ago (2015-07-01 07:55:30 UTC) #4
Henrik Grunell WebRTC
lgtm
5 years, 5 months ago (2015-07-01 08:39:20 UTC) #5
jiayl
lgtm
5 years, 5 months ago (2015-07-01 18:50:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216353002/1
5 years, 5 months ago (2015-07-01 18:51:03 UTC) #9
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 18:52:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216353002/20001
5 years, 5 months ago (2015-07-01 19:41:15 UTC) #14
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 19:55:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216353002/20001
5 years, 5 months ago (2015-07-01 20:56:59 UTC) #18
commit-bot: I haz the power
Exceeded global retry quota
5 years, 5 months ago (2015-07-01 20:58:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216353002/40001
5 years, 5 months ago (2015-07-01 23:11:05 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/81)
5 years, 5 months ago (2015-07-01 23:17:50 UTC) #25
dcheng
TBR jiayl@webrtc.org (jiayl@chromium.org LGTMed)
5 years, 5 months ago (2015-07-01 23:22:16 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216353002/40001
5 years, 5 months ago (2015-07-01 23:22:27 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-02 00:52:16 UTC) #29
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 00:52:27 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a771bf8ee84f293c166d3e377d852e9705c12725
Cr-Commit-Position: refs/heads/master@{#9529}

Powered by Google App Engine
This is Rietveld 408576698