Removing AudioMixerStatusReceiver and ParticipantStatistics

Removing AudioMixerStatusReceiver and ParticipantStatistics.

BUG=webrtc:497
R=ajm@chromium.org, andrew@webrtc.org, henrikg@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/4540ffacc774b2c9a54155c4312dfe8263fd4de3

[minyue-webrtc, 2015-07-06 13:48:21]

minyue@webrtc.org changed reviewers:
+ andrew@webrtc.org

[minyue-webrtc, 2015-07-06 14:03:46]

Patchset #1 (id:1) has been deleted

[minyue-webrtc, 2015-07-06 15:13:15]

Hi Andrew,

Could you help review this?

[minyue-webrtc, 2015-07-07 08:55:40]

On 2015/07/06 15:13:15, minyuel wrote:
> Hi Andrew,
> 
> Could you help review this?

Hi Andrew,

I went even further to remove LevelIndicator completely in patch set 2. Please
take a look at it as well.

[Andrew MacDonald, 2015-07-07 17:31:09]

andrew@webrtc.org changed reviewers:
+ tomasl@google.com

[Andrew MacDonald, 2015-07-07 17:33:32]

Tomas, can you confirm that this stuff isn't needed? A codesearch suggests it
isn't.

[minyue-webrtc, 2015-07-09 08:17:49]

On 2015/07/07 17:33:32, andrew wrote:
> Tomas, can you confirm that this stuff isn't needed? A codesearch suggests it
> isn't.

Tomas told me offline that level indicator is not used.

[minyue-webrtc, 2015-07-20 08:57:43]

On 2015/07/09 08:17:49, minyuel wrote:
> On 2015/07/07 17:33:32, andrew wrote:
> > Tomas, can you confirm that this stuff isn't needed? A codesearch suggests
it
> > isn't.
> 
> Tomas told me offline that level indicator is not used.

Ping Andrew, if you are back from Vacation.

[ajm, 2015-07-25 01:46:12]

ajm@chromium.org changed reviewers:
+ ajm@chromium.org

[ajm, 2015-07-25 01:46:12]

Nice, lgtm with one small comment change.

https://codereview.chromium.org/1216133004/diff/40001/webrtc/modules/audio_co...
File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h
(left):

https://codereview.chromium.org/1216133004/diff/40001/webrtc/modules/audio_co...
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h:97:
// participants who's AudioFrames are inside mixList.
who's -> whose

[ajm, 2015-07-25 02:01:48]

Ah, but actually, do you know why this uploaded to codereview.chromium.org? It
_probably_ doesn't matter, but best if you could re-upload to
codereview.webrtc.org.

[minyue-webrtc, 2015-07-27 13:10:13]

https://codereview.chromium.org/1216133004/diff/40001/webrtc/modules/audio_co...
File webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h
(left):

https://codereview.chromium.org/1216133004/diff/40001/webrtc/modules/audio_co...
webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h:97:
// participants who's AudioFrames are inside mixList.
On 2015/07/25 01:46:12, ajm wrote:
> who's -> whose

This is a removed line

[minyue-webrtc, 2015-07-27 13:14:19]

https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
File webrtc/voice_engine/output_mixer.cc (right):

https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
webrtc/voice_engine/output_mixer.cc:34: _audioFrame.CopyFrom(generalAudioFrame);
Add a random comment to see where it linkes to.

It shows codereview.webrtc.org instead of codereview.chromium.org to me. I think
it depends on weather you join with codereview.webrtc.org or the other.

But they points at the same place.

[minyue-webrtc, 2015-07-27 14:11:19]

minyue@webrtc.org changed reviewers:
+ henrikg@webrtc.org

[minyue-webrtc, 2015-07-27 14:12:44]

On 2015/07/27 13:14:19, minyuel wrote:
>
https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
> File webrtc/voice_engine/output_mixer.cc (right):
> 
>
https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
> webrtc/voice_engine/output_mixer.cc:34:
_audioFrame.CopyFrom(generalAudioFrame);
> Add a random comment to see where it linkes to.
> 
> It shows http://codereview.webrtc.org instead of
http://codereview.chromium.org to me. I think
> it depends on weather you join with http://codereview.webrtc.org or the other.
> 
> But they points at the same place.

+henrikg

Hi Henrik,

Please take a look at this CL. I need your owner's approval on the VoE part.

[minyue-webrtc, 2015-07-27 14:13:03]

On 2015/07/27 14:12:44, minyuel wrote:
> On 2015/07/27 13:14:19, minyuel wrote:
> >
>
https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
> > File webrtc/voice_engine/output_mixer.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
> > webrtc/voice_engine/output_mixer.cc:34:
> _audioFrame.CopyFrom(generalAudioFrame);
> > Add a random comment to see where it linkes to.
> > 
> > It shows http://codereview.webrtc.org instead of
> http://codereview.chromium.org to me. I think
> > it depends on weather you join with http://codereview.webrtc.org or the
other.
> > 
> > But they points at the same place.
> 
> +henrikg
> 
> Hi Henrik,
> 
> Please take a look at this CL. I need your owner's approval on the VoE part.

Hi Andrew,

I need your owner's approval from andrew@webrtc.org

[Henrik Grunell WebRTC, 2015-07-27 14:59:34]

webrtc/voice_engine lgtm

[Andrew MacDonald, 2015-07-27 16:48:04]

On 2015/07/27 13:14:19, minyuel wrote:
>
https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
> File webrtc/voice_engine/output_mixer.cc (right):
> 
>
https://codereview.webrtc.org/1216133004/diff/20001/webrtc/voice_engine/outpu...
> webrtc/voice_engine/output_mixer.cc:34:
_audioFrame.CopyFrom(generalAudioFrame);
> Add a random comment to see where it linkes to.
> 
> It shows http://codereview.webrtc.org instead of
http://codereview.chromium.org to me. I think
> it depends on weather you join with http://codereview.webrtc.org or the other.
> 
> But they points at the same place.

Yeah, weird, I'm not sure how I ended up on codereview.chromium.org.

[Andrew MacDonald, 2015-07-27 16:49:48]

lgtm

[minyue-webrtc, 2015-07-28 09:07:41]

Committed patchset #2 (id:40001) manually as
4540ffacc774b2c9a54155c4312dfe8263fd4de3 (presubmit successful).