Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1215713019: Fix follow-up in webrtc/test/field_trial.cc. (Closed)

Created:
5 years, 5 months ago by pbos-webrtc
Modified:
5 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix follow-up in webrtc/test/field_trial.cc. BUG=webrtc:4820 R=tommi@webrtc.org Committed: https://crrev.com/4d9d09721734da31b5e28980f6a1fefee42cb409 Cr-Commit-Position: refs/heads/master@{#9563}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M webrtc/test/field_trial.cc View 1 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
pbos-webrtc
PTAL
5 years, 5 months ago (2015-07-08 12:10:42 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215713019/1
5 years, 5 months ago (2015-07-08 12:10:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-08 13:29:44 UTC) #5
tommi
lgtm - but maybe this is obsolete now https://codereview.webrtc.org/1215713019/diff/1/webrtc/test/field_trial.cc File webrtc/test/field_trial.cc (right): https://codereview.webrtc.org/1215713019/diff/1/webrtc/test/field_trial.cc#newcode98 webrtc/test/field_trial.cc:98: assert(field_trials_initiated_); ...
5 years, 5 months ago (2015-07-09 20:09:58 UTC) #6
pbos-webrtc
rebase
5 years, 5 months ago (2015-07-09 22:55:26 UTC) #7
pbos-webrtc
https://codereview.webrtc.org/1215713019/diff/1/webrtc/test/field_trial.cc File webrtc/test/field_trial.cc (right): https://codereview.webrtc.org/1215713019/diff/1/webrtc/test/field_trial.cc#newcode98 webrtc/test/field_trial.cc:98: assert(field_trials_initiated_); On 2015/07/09 20:09:58, tommi (webrtc) wrote: > Thanks ...
5 years, 5 months ago (2015-07-09 22:55:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215713019/20001
5 years, 5 months ago (2015-07-09 22:56:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 00:21:10 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 00:21:17 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d9d09721734da31b5e28980f6a1fefee42cb409
Cr-Commit-Position: refs/heads/master@{#9563}

Powered by Google App Engine
This is Rietveld 408576698