webrtc/p2p/client/basicportallocator.h - Issue 1215713003: Ensuring that UDP TURN servers are always used as STUN servers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/client/basicportallocator.h

Issue 1215713003: Ensuring that UDP TURN servers are always used as STUN servers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Actually use non-shared socket mode for unit test, as intended. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/p2p/client/basicportallocator.h

diff --git a/webrtc/p2p/client/basicportallocator.h b/webrtc/p2p/client/basicportallocator.h

index 96468d32ccafab6eb574909c9a34cfffa9897bc6..f2d92ef64ea6512fe0a8100965e60b410c0ca24d 100644

--- a/webrtc/p2p/client/basicportallocator.h

+++ b/webrtc/p2p/client/basicportallocator.h

@@ -220,7 +220,8 @@ struct PortConfiguration : public rtc::MessageData {

const std::string& username,

const std::string& password);

- // TODO(jiayl): remove when |stun_address| is removed.

+ // Returns addresses of both the explicitly configured STUN servers,

+ // and TURN servers that should be used as STUN servers.

ServerAddresses StunServers();

// Adds another relay server, with the given ports and modifier, to the list.

« no previous file with comments | « no previous file | webrtc/p2p/client/basicportallocator.cc » ('j') | webrtc/p2p/client/basicportallocator.cc » ('J')