Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: webrtc/video/screenshare_loopback.cc

Issue 1215113003: Added FullStack performance test for screensharing with VP9 (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: editing comments and reverting timeout Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/full_stack.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/screenshare_loopback.cc
diff --git a/webrtc/video/screenshare_loopback.cc b/webrtc/video/screenshare_loopback.cc
index a3084249811d8b205a8ef96ed748c529eebdfc0f..8f0ab63da572aec14aca9cdc5da0f562a6d5041f 100644
--- a/webrtc/video/screenshare_loopback.cc
+++ b/webrtc/video/screenshare_loopback.cc
@@ -132,6 +132,11 @@ class ScreenshareLoopback : public test::Loopback {
vp8_settings_.denoisingOn = false;
vp8_settings_.frameDroppingOn = false;
vp8_settings_.numberOfTemporalLayers = 2;
+
+ vp9_settings_ = VideoEncoder::GetDefaultVp9Settings();
+ vp9_settings_.denoisingOn = false;
+ vp9_settings_.frameDroppingOn = false;
+ vp9_settings_.numberOfTemporalLayers = 2;
}
virtual ~ScreenshareLoopback() {}
@@ -141,7 +146,14 @@ class ScreenshareLoopback : public test::Loopback {
VideoStream* stream = &encoder_config.streams[0];
encoder_config.content_type = VideoEncoderConfig::ContentType::kScreen;
encoder_config.min_transmit_bitrate_bps = flags::MinTransmitBitrate();
- encoder_config.encoder_specific_settings = &vp8_settings_;
+ if (config_.codec == "VP8") {
+ encoder_config.encoder_specific_settings = &vp8_settings_;
+ } else if (config_.codec == "VP9") {
+ encoder_config.encoder_specific_settings = &vp9_settings_;
+ } else {
+ RTC_NOTREACHED() << "Codec not supported!";
+ abort();
+ }
stream->temporal_layer_thresholds_bps.clear();
stream->target_bitrate_bps =
static_cast<int>(config_.start_bitrate_kbps) * 1000;
@@ -178,6 +190,7 @@ class ScreenshareLoopback : public test::Loopback {
}
VideoCodecVP8 vp8_settings_;
+ VideoCodecVP9 vp9_settings_;
};
void Loopback() {
« no previous file with comments | « webrtc/video/full_stack.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698