Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1215053002: Remove a cast again, after it was shown to worsen Windows perf. (Closed)

Created:
5 years, 5 months ago by Peter Kasting
Modified:
5 years, 5 months ago
Reviewers:
Andrew MacDonald
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, bjornv1, aluebs-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove a cast again, after it was shown to worsen Windows perf. This will hurt Linux x64 perf, but we think that's a compiler bug and we're willing to take the hit for the better clarity of the code sans cast as well as the better Windows perf. Hopefully eventually the compiler will improve. BUG=504813 TEST=none TBR=andrew Committed: https://crrev.com/3c60d614636a858e18fda9e52045fd1192517b8d Cr-Commit-Position: refs/heads/master@{#9516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M webrtc/common_audio/signal_processing/cross_correlation.c View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
5 years, 5 months ago (2015-06-29 21:34:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215053002/1
5 years, 5 months ago (2015-06-29 21:34:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 22:16:47 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3c60d614636a858e18fda9e52045fd1192517b8d Cr-Commit-Position: refs/heads/master@{#9516}
5 years, 5 months ago (2015-06-29 22:16:55 UTC) #6
Andrew MacDonald
5 years, 5 months ago (2015-06-29 22:52:13 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698