Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1214713005: Removed some unused variables in Windows code. (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
webrtc-reviews_webrtc.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed some unused variables in Windows code. Note: Regarding the ICMP6_CLOSE_FUNC variable in winping.cc, Icmp6CloseHandle does not exist, and IcmpCloseHandle is the correct way to close an IPv6 handle. Therefore the existing code is correct to use close_ on both types of connections and this variable is unnecessary. BUG=505319

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/winping.cc View 1 chunk +0 lines, -1 line 0 comments Download
M modules/desktop_capture/win/cursor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
Matt Giuca
5 years, 5 months ago (2015-07-03 01:58:28 UTC) #2
Sergey Ulanov
lgtm
5 years, 5 months ago (2015-07-06 17:59:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214713005/1
5 years, 5 months ago (2015-07-07 00:13:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/1165) android_gn on tryserver.webrtc (JOB_FAILED, ...
5 years, 5 months ago (2015-07-07 00:14:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214713005/20001
5 years, 5 months ago (2015-07-07 00:30:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/1167) ios32_sim on tryserver.webrtc (JOB_FAILED, ...
5 years, 5 months ago (2015-07-07 00:30:57 UTC) #12
Matt Giuca
Sergey: I keep getting patch failures on the try bots: While running git apply --index ...
5 years, 5 months ago (2015-07-07 00:32:18 UTC) #13
Matt Giuca
Ping. I saw in your documentation that I'm to use "git cl land". I tried ...
5 years, 5 months ago (2015-07-08 03:26:17 UTC) #15
Sergey Ulanov
On 2015/07/08 03:26:17, Matt Giuca wrote: > Ping. I saw in your documentation that I'm ...
5 years, 5 months ago (2015-07-08 19:31:38 UTC) #16
Matt Giuca
5 years, 5 months ago (2015-07-09 00:41:33 UTC) #17
Message was sent while issue was closed.
Oh, I didn't notice the difference in the URLs :( This is confusing.

See:
https://codereview.webrtc.org/1231653003/

Powered by Google App Engine
This is Rietveld 408576698