Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1214113015: Update AppRTCDemo resolution for iPhone6/6+ (Closed)

Created:
5 years, 5 months ago by tkchin_webrtc
Modified:
5 years, 5 months ago
Reviewers:
jiayl2
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update AppRTCDemo resolution for iPhone6/6+ BUG= Committed: https://crrev.com/0d7dbde8cf57b0492c6988cb3bdca9933ce86d55 Cr-Commit-Position: refs/heads/master@{#9530}

Patch Set 1 #

Patch Set 2 : Fix corrupted images #

Patch Set 3 : Fix names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -63 lines) Patch
M talk/examples/objc/AppRTCDemo/ios/Info.plist View 1 2 1 chunk +91 lines, -62 lines 0 comments Download
D talk/examples/objc/AppRTCDemo/ios/resources/Default-568h.png View Binary file 0 comments Download
A talk/examples/objc/AppRTCDemo/ios/resources/iPhone5@2x.png View 1 2 Binary file 0 comments Download
A talk/examples/objc/AppRTCDemo/ios/resources/iPhone6@2x.png View Binary file 0 comments Download
A talk/examples/objc/AppRTCDemo/ios/resources/iPhone6p@3x.png View 1 2 Binary file 0 comments Download
M talk/libjingle_examples.gyp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
tkchin_webrtc
5 years, 5 months ago (2015-07-01 21:38:02 UTC) #2
jiayl2
lgtm
5 years, 5 months ago (2015-07-01 23:01:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1214113015/60001
5 years, 5 months ago (2015-07-02 00:17:59 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 5 months ago (2015-07-02 01:26:41 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 01:26:45 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d7dbde8cf57b0492c6988cb3bdca9933ce86d55
Cr-Commit-Position: refs/heads/master@{#9530}

Powered by Google App Engine
This is Rietveld 408576698