webrtc/modules/audio_processing/audio_processing_impl.h - Issue 1213733004: Adds UMA histogram for system delay jumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/audio_processing_impl.h

Issue 1213733004: Adds UMA histogram for system delay jumps (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: includes base/checks.h Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/audio_processing_impl.h

diff --git a/webrtc/modules/audio_processing/audio_processing_impl.h b/webrtc/modules/audio_processing/audio_processing_impl.h

index 895294dc60bdc8bd0f0452a7b9e47a20e9c3c301..6f237ae4dc84df14917777fdefd6041106875d65 100644

--- a/webrtc/modules/audio_processing/audio_processing_impl.h

+++ b/webrtc/modules/audio_processing/audio_processing_impl.h

@@ -171,6 +171,7 @@ class AudioProcessingImpl : public AudioProcessing {

void InitializeExperimentalAgc() EXCLUSIVE_LOCKS_REQUIRED(crit_);

void InitializeTransient() EXCLUSIVE_LOCKS_REQUIRED(crit_);

void InitializeBeamformer() EXCLUSIVE_LOCKS_REQUIRED(crit_);

+ void MaybeUpdateHistograms() EXCLUSIVE_LOCKS_REQUIRED(crit_);

EchoCancellationImpl* echo_cancellation_;

EchoControlMobileImpl* echo_control_mobile_;

@@ -207,6 +208,8 @@ class AudioProcessingImpl : public AudioProcessing {

int stream_delay_ms_;

int delay_offset_ms_;

bool was_stream_delay_set_;

+ int last_stream_delay_ms_;

+ int last_aec_system_delay_ms_;

bool output_will_be_muted_ GUARDED_BY(crit_);

« no previous file with comments | « no previous file | webrtc/modules/audio_processing/audio_processing_impl.cc » ('j') | no next file with comments »