Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: webrtc/voice_engine/channel.cc

Issue 1213603002: Remove ResetStatistics from RTP feedback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove more data counter resetting. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/video_engine/vie_channel.cc ('K') | « webrtc/voice_engine/channel.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/channel.cc
diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc
index 6dd64c7634a99dedf8b6fd5cf43124b8a8a2e48e..8992425b537b0e32d329a470d58fe50d2619171d 100644
--- a/webrtc/voice_engine/channel.cc
+++ b/webrtc/voice_engine/channel.cc
@@ -74,11 +74,6 @@ class StatisticsProxy : public RtcpStatisticsCallback {
void CNameChanged(const char* cname, uint32_t ssrc) override {}
- void ResetStatistics() {
- CriticalSectionScoped cs(stats_lock_.get());
- stats_ = ChannelStatistics();
- }
-
ChannelStatistics GetStats() {
CriticalSectionScoped cs(stats_lock_.get());
return stats_;
@@ -340,15 +335,6 @@ void Channel::OnIncomingCSRCChanged(int32_t id,
id, CSRC, added);
}
-void Channel::ResetStatistics(uint32_t ssrc) {
- StreamStatistician* statistician =
- rtp_receive_statistics_->GetStatistician(ssrc);
- if (statistician) {
- statistician->ResetStatistics();
- }
- statistics_proxy_->ResetStatistics();
-}
-
int32_t
Channel::OnInitializeDecoder(
int32_t id,
@@ -1206,8 +1192,7 @@ Channel::StopSend()
// Reset sending SSRC and sequence number and triggers direct transmission
// of RTCP BYE
- if (_rtpRtcpModule->SetSendingStatus(false) == -1 ||
- _rtpRtcpModule->ResetSendDataCountersRTP() == -1)
+ if (_rtpRtcpModule->SetSendingStatus(false) == -1)
{
_engineStatisticsPtr->SetLastError(
VE_RTP_RTCP_MODULE_ERROR, kTraceWarning,
« webrtc/video_engine/vie_channel.cc ('K') | « webrtc/voice_engine/channel.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698