Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 1212653012: Follow-up: Remove old ReportedDelay AEC config (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_processing/echo_cancellation_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index 80b7b4d2f3caf7efe4e1f3c19f473538e5fbec12..e2b38052d86c742a34d4de3c94fe6b1bbb1ec100 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -60,20 +60,11 @@ struct ExtendedFilter {
bool enabled;
};
-// Use to disable the reported system delays. By disabling the reported system
-// delays the echo cancellation algorithm assumes the process and reverse
-// streams to be aligned. This configuration only applies to EchoCancellation
-// and not EchoControlMobile and is set with AudioProcessing::SetExtraOptions().
-// Note that by disabling reported system delays the EchoCancellation may
-// regress in performance.
-// TODO(henrik.lundin): Remove ReportedDelay once DelayAgnostic has
-// propagated through to all channels
-// (https://code.google.com/p/webrtc/issues/detail?id=4651).
-struct ReportedDelay {
- ReportedDelay() : enabled(true) {}
- explicit ReportedDelay(bool enabled) : enabled(enabled) {}
- bool enabled;
-};
+// Enables delay-agnostic echo cancellation. This feature relies on internally
+// estimated delays between the process and reverse streams, thus not relying
+// on reported system delays. This configuration only applies to
+// EchoCancellation and not EchoControlMobile and is set with
+// AudioProcessing::SetExtraOptions().
bjornv1 2015/07/03 06:22:16 Change to "It can be set in the constructor or usi
hlundin-webrtc 2015/07/03 07:07:11 Done.
struct DelayAgnostic {
DelayAgnostic() : enabled(false) {}
explicit DelayAgnostic(bool enabled) : enabled(enabled) {}
« no previous file with comments | « webrtc/modules/audio_processing/echo_cancellation_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698