Follow-up: Remove old ReportedDelay AEC config

Follow-up: Remove old ReportedDelay AEC config

This is a follow-up to r9531, where the configuration ReportedDelay
was replaced by DelayAgnostic. The config was kept in the code to
avoid API breakages. In https://codereview.chromium.org/1219263003/
depending code has been updated to avoid breakages.

BUG=webrtc:4651
R=bjornv@webrtc.org

Committed: https://crrev.com/366e95252aba863f886aa692459bf267e5525d86
Cr-Commit-Position: refs/heads/master@{#9536}

[hlundin-webrtc, 2015-07-03 05:56:03]

Björn, please, take a look.

[bjornv1, 2015-07-03 06:22:16]

lgtm with a correct description

https://codereview.webrtc.org/1212653012/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/include/audio_processing.h (right):

https://codereview.webrtc.org/1212653012/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/include/audio_processing.h:67: //
AudioProcessing::SetExtraOptions().
Change to
"It can be set in the constructor or using AudioProcessing::SetExtraOptions()."

Not needed to state explicitly, but it is advised to be set in the constructor
and not through SetExtraOptions(). In fact, it is hazardous to use
SetExtraOptions(), since you may lose previously set Configs.

[hlundin-webrtc, 2015-07-03 07:06:46]

Fixing comment

[hlundin-webrtc, 2015-07-03 07:07:11]

Thanks!

https://codereview.webrtc.org/1212653012/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/include/audio_processing.h (right):

https://codereview.webrtc.org/1212653012/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/include/audio_processing.h:67: //
AudioProcessing::SetExtraOptions().
On 2015/07/03 06:22:16, bjornv1 wrote:
> Change to
> "It can be set in the constructor or using
AudioProcessing::SetExtraOptions()."
> 
> Not needed to state explicitly, but it is advised to be set in the constructor
> and not through SetExtraOptions(). In fact, it is hazardous to use
> SetExtraOptions(), since you may lose previously set Configs.

Done.

[hlundin-webrtc, 2015-07-03 07:07:15]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2015-07-03 07:07:16]

The patchset sent to the CQ was uploaded after l-g-t-m from bjornv@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1212653012/#ps20001 (title:
"Fixing comment")

[commit-bot: I haz the power, 2015-07-03 07:07:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1212653012/20001

[commit-bot: I haz the power, 2015-07-03 07:50:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-03 07:50:20]

Patchset 2 (id:??) landed as
https://crrev.com/366e95252aba863f886aa692459bf267e5525d86
Cr-Commit-Position: refs/heads/master@{#9536}