remoting/host/cast_extension_session.cc - Issue 1211323013: Stop calling deprecated version of "CreateIceCandidate".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/cast_extension_session.cc

Issue 1211323013: Stop calling deprecated version of "CreateIceCandidate". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use nullptr instead of NULL. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/cast_extension_session.cc

diff --git a/remoting/host/cast_extension_session.cc b/remoting/host/cast_extension_session.cc

index d43beff9a49e244e39b2277aca2f015f9e07ed20..33fe308f75a72fb2103d35f8f86fb0d656c24de6 100644

--- a/remoting/host/cast_extension_session.cc

+++ b/remoting/host/cast_extension_session.cc

@@ -389,7 +389,8 @@ bool CastExtensionSession::ParseAndAddICECandidate(

}

rtc::scoped_ptr<webrtc::IceCandidateInterface> candidate(

- webrtc::CreateIceCandidate(sdp_mid, sdp_mlineindex, candidate_str));

+ webrtc::CreateIceCandidate(sdp_mid, sdp_mlineindex, candidate_str,

+ nullptr));

Sergey Ulanov 2015/07/06 18:03:19 please fix indentation. This argument should be al

joachim 2015/07/07 08:52:20 Done.

if (!candidate.get()) {

LOG(ERROR)

<< "Invalid Cast Extension Message (could not create candidate).";

« no previous file with comments | « content/renderer/media/webrtc/peer_connection_dependency_factory.cc ('k') | no next file » | no next file with comments »