Rename APM Config ReportedDelay to DelayAgnostic

webrtc/modules/audio_processing/aec/aec_core_internal.h

Index: webrtc/modules/audio_processing/aec/aec_core_internal.h
diff --git a/webrtc/modules/audio_processing/aec/aec_core_internal.h b/webrtc/modules/audio_processing/aec/aec_core_internal.h
index 2f795896f5115d3a464405e5e0c904e5bcb0794f..796ea2c9c0667d1204e9127dc9da844eb8fbb5cf 100644
--- a/webrtc/modules/audio_processing/aec/aec_core_internal.h
+++ b/webrtc/modules/audio_processing/aec/aec_core_internal.h
@@ -144,9 +144,9 @@ struct AecCore {
   float delay_quality_threshold;
   int frame_count;
 
-  // 0 = reported delay mode disabled (signal based delay correction enabled).
-  // otherwise enabled
-  int reported_delay_enabled;
+  // 0 = delay agnostic mode (signal based delay correction) disabled.
+  // Otherwise enabled.
+  int delay_agnostic_enabled;

[tommi, 2015/07/01 14:00:45]

why do we use int for these?
(e.g. why not int foo:1 assuming this is C code)

[hlundin-webrtc, 2015/07/02 06:36:30]

Because... legacy. And for the record, int foo:1 is a bad idea, since at least
our compiler implements a signed 1-bit field to have the range {-1, 0}. This
leads to very awkward logic (0 == false, -1 == true). Changing to unsigned foo:1
works as expected.

But, I doubt that saving one int is worth the effort.

[tommi, 2015/07/08 13:44:43]

Well, -1 is true, so is 0xffff and 0xffffffff.  (see e.g.
http://blogs.msdn.com/b/oldnewthing/archive/2004/12/22/329884.aspx)
The only constant is 0==FALSE==false==VARIANT_FALSE etc, so whenever I see code
that checks for |== true| I need to make sure that that's the only possible
"true" value.  is !false == 1 or is !false==!0?  Anyway, agree on unsigned being
better regardless.

I just saw a few would-be bool member variables declared as int, so had to ask.

[kwiberg-webrtc, 2015/07/08 14:47:59]

I hope you won't find a compiler where this isn't the case. An n-bit two's
complement integer should have 1 sign bit and n-1 "value" bits, which gives
minimum value -2^(n-1) and maximum value 2^(n-1) - 1. For n = 1, that's -1 and
0.

   // 1 = extended filter mode enabled, 0 = disabled.
   int extended_filter_enabled;
   // Runtime selection of number of filter partitions.