Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: webrtc/modules/audio_processing/echo_cancellation_impl_unittest.cc

Issue 1211053006: Rename APM Config ReportedDelay to DelayAgnostic (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix error in android test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 30 matching lines...) Expand all
41 41
42 config.Set<ExtendedFilter>(new ExtendedFilter(false)); 42 config.Set<ExtendedFilter>(new ExtendedFilter(false));
43 ap->SetExtraOptions(config); 43 ap->SetExtraOptions(config);
44 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 44 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
45 45
46 // Retains setting after initialization. 46 // Retains setting after initialization.
47 EXPECT_EQ(ap->kNoError, ap->Initialize()); 47 EXPECT_EQ(ap->kNoError, ap->Initialize());
48 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core)); 48 EXPECT_EQ(0, WebRtcAec_extended_filter_enabled(aec_core));
49 } 49 }
50 50
51 TEST(EchoCancellationInternalTest, ReportedDelay) { 51 TEST(EchoCancellationInternalTest, DelayAgnostic) {
52 rtc::scoped_ptr<AudioProcessing> ap(AudioProcessing::Create()); 52 rtc::scoped_ptr<AudioProcessing> ap(AudioProcessing::Create());
53 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL); 53 EXPECT_TRUE(ap->echo_cancellation()->aec_core() == NULL);
54 54
55 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true)); 55 EXPECT_EQ(ap->kNoError, ap->echo_cancellation()->Enable(true));
56 EXPECT_TRUE(ap->echo_cancellation()->is_enabled()); 56 EXPECT_TRUE(ap->echo_cancellation()->is_enabled());
57 57
58 AecCore* aec_core = ap->echo_cancellation()->aec_core(); 58 AecCore* aec_core = ap->echo_cancellation()->aec_core();
59 ASSERT_TRUE(aec_core != NULL); 59 ASSERT_TRUE(aec_core != NULL);
60 // Enabled by default. 60 // Enabled by default.
61 EXPECT_EQ(1, WebRtcAec_reported_delay_enabled(aec_core)); 61 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
62 62
63 Config config; 63 Config config;
64 config.Set<ReportedDelay>(new ReportedDelay(false)); 64 config.Set<DelayAgnostic>(new DelayAgnostic(true));
65 ap->SetExtraOptions(config); 65 ap->SetExtraOptions(config);
66 EXPECT_EQ(0, WebRtcAec_reported_delay_enabled(aec_core)); 66 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core));
67 67
68 // Retains setting after initialization. 68 // Retains setting after initialization.
69 EXPECT_EQ(ap->kNoError, ap->Initialize()); 69 EXPECT_EQ(ap->kNoError, ap->Initialize());
70 EXPECT_EQ(0, WebRtcAec_reported_delay_enabled(aec_core)); 70 EXPECT_EQ(1, WebRtcAec_delay_agnostic_enabled(aec_core));
71 71
72 config.Set<ReportedDelay>(new ReportedDelay(true)); 72 config.Set<DelayAgnostic>(new DelayAgnostic(false));
73 ap->SetExtraOptions(config); 73 ap->SetExtraOptions(config);
74 EXPECT_EQ(1, WebRtcAec_reported_delay_enabled(aec_core)); 74 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
75 75
76 // Retains setting after initialization. 76 // Retains setting after initialization.
77 EXPECT_EQ(ap->kNoError, ap->Initialize()); 77 EXPECT_EQ(ap->kNoError, ap->Initialize());
78 EXPECT_EQ(1, WebRtcAec_reported_delay_enabled(aec_core)); 78 EXPECT_EQ(0, WebRtcAec_delay_agnostic_enabled(aec_core));
79 } 79 }
80 80
81 } // namespace webrtc 81 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/audio_processing/echo_cancellation_impl.cc ('k') | webrtc/modules/audio_processing/include/audio_processing.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698