Ensure transient suppression is never enabled on mobile.

Ensure transient suppression is never enabled on mobile.

Committed: https://crrev.com/1c7075f076987f31c280060b855b6a31312895a6
Cr-Commit-Position: refs/heads/master@{#9500}

[Andrew MacDonald, 2015-06-24 17:05:59]

andrew@webrtc.org changed reviewers:
+ aluebs@webrtc.org

[aluebs-webrtc, 2015-06-24 17:25:43]

lgtm % a small comment

https://codereview.webrtc.org/1209653002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1209653002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:181: #if
defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
Do we want to put this in the same ifdef than the use_new_agc_?

[Andrew MacDonald, 2015-06-24 17:51:47]

https://codereview.webrtc.org/1209653002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1209653002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:181: #if
defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
On 2015/06/24 17:25:43, aluebs-webrtc wrote:
> Do we want to put this in the same ifdef than the use_new_agc_?

We could, but it would constrain the order of member definitions (i.e.
agc_startup_min_volume_ would have to move). What's worse?

[aluebs-webrtc, 2015-06-24 17:54:00]

lgtm

https://codereview.webrtc.org/1209653002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/audio_processing_impl.cc (right):

https://codereview.webrtc.org/1209653002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/audio_processing_impl.cc:181: #if
defined(WEBRTC_ANDROID) || defined(WEBRTC_IOS)
On 2015/06/24 17:51:47, andrew wrote:
> On 2015/06/24 17:25:43, aluebs-webrtc wrote:
> > Do we want to put this in the same ifdef than the use_new_agc_?
> 
> We could, but it would constrain the order of member definitions (i.e.
> agc_startup_min_volume_ would have to move). What's worse?

I am ok with leaving it this way, but do whatever you think is best.

[Andrew MacDonald, 2015-06-25 01:11:43]

The CQ bit was checked by andrew@webrtc.org

[commit-bot: I haz the power, 2015-06-25 01:11:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1209653002/1

[commit-bot: I haz the power, 2015-06-25 01:14:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-25 01:14:23]

Patchset 1 (id:??) landed as
https://crrev.com/1c7075f076987f31c280060b855b6a31312895a6
Cr-Commit-Position: refs/heads/master@{#9500}