Add utility class for unwrapping 16 bit sequence numbers

Add utility class for unwrapping 16 bit sequence numbers

Unwrap uint16_t to int64_t, based on delta and last sequence number.
This can make application logic, putting packets in maps etc, much
simpler.

BUG=

Committed: https://crrev.com/c3aa12d5f2df45bce1387020ac159792342d525f
Cr-Commit-Position: refs/heads/master@{#9887}

[sprang_webrtc, 2015-06-24 16:19:49]

sprang@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[sprang_webrtc, 2015-07-23 14:00:04]

Ping?

[sprang_webrtc, 2015-08-31 13:20:55]

Ping, third month's the charm..?

[mflodman, 2015-09-03 12:00:13]

Oh, I thought, foe some reason, this CL was abandoned.

One question, but I have a few other as well that might be easiest to take
offline.

https://codereview.webrtc.org/1209623002/diff/1/webrtc/modules/interface/modu...
File webrtc/modules/interface/module_common_types.h (right):

https://codereview.webrtc.org/1209623002/diff/1/webrtc/modules/interface/modu...
webrtc/modules/interface/module_common_types.h:637: int64_t
UnwrapWithoutUpdate(uint16_t sequence_number) {
Should this method be private?

[sprang_webrtc, 2015-09-03 13:28:02]

https://codereview.webrtc.org/1209623002/diff/1/webrtc/modules/interface/modu...
File webrtc/modules/interface/module_common_types.h (right):

https://codereview.webrtc.org/1209623002/diff/1/webrtc/modules/interface/modu...
webrtc/modules/interface/module_common_types.h:637: int64_t
UnwrapWithoutUpdate(uint16_t sequence_number) {
On 2015/09/03 12:00:13, mflodman wrote:
> Should this method be private?

No, I'm using this :)

[stefan-webrtc, 2015-09-07 10:14:33]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2015-09-07 10:14:34]

One comment request, otherwise this lgtm.

https://codereview.webrtc.org/1209623002/diff/20001/webrtc/modules/interface/...
File webrtc/modules/interface/module_common_types.h (right):

https://codereview.webrtc.org/1209623002/diff/20001/webrtc/modules/interface/...
webrtc/modules/interface/module_common_types.h:646: } else if (delta > 0 &&
(last_seq_ + delta - (1 << 16)) >= 0) {
It could be good to comment the second part of this check to make it clear that
it's just a check to make sure we don't wrap correct last_seq_ into something
negative.

[sprang_webrtc, 2015-09-07 11:28:47]

https://codereview.webrtc.org/1209623002/diff/20001/webrtc/modules/interface/...
File webrtc/modules/interface/module_common_types.h (right):

https://codereview.webrtc.org/1209623002/diff/20001/webrtc/modules/interface/...
webrtc/modules/interface/module_common_types.h:646: } else if (delta > 0 &&
(last_seq_ + delta - (1 << 16)) >= 0) {
On 2015/09/07 10:14:34, stefan-webrtc (holmer) wrote:
> It could be good to comment the second part of this check to make it clear
that
> it's just a check to make sure we don't wrap correct last_seq_ into something
> negative.

Done.

[sprang_webrtc, 2015-09-07 14:40:59]

ping mflodman@, as root owner

[mflodman, 2015-09-08 08:50:47]

lgtm

[sprang_webrtc, 2015-09-08 08:52:32]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2015-09-08 08:52:32]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1209623002/#ps40001 (title:
"Added comment")

[commit-bot: I haz the power, 2015-09-08 08:52:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1209623002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1209623002/40001

[commit-bot: I haz the power, 2015-09-08 10:43:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-08 10:43:31]

Patchset 3 (id:??) landed as
https://crrev.com/c3aa12d5f2df45bce1387020ac159792342d525f
Cr-Commit-Position: refs/heads/master@{#9887}