Removed extended jitter report from RtcpSender

Removed extended jitter report from RtcpSender.
This was never used (value always 0, when sent)

BUG=2450
R=asapersson@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/a38233a586dd865c0cd728ce523b3a82ca52ea8b

[sprang_webrtc, 2015-06-25 12:49:09]

sprang@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[åsapersson, 2015-06-25 15:14:26]

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (left):

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:601:
ctx->jitter_transmission_offset);
Not related to this cl but it seems like ctx->jitter_transmission_offset is
always zero?

[sprang_webrtc, 2015-07-08 08:57:59]

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (left):

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:601:
ctx->jitter_transmission_offset);
On 2015/06/25 15:14:25, asapersson wrote:
> Not related to this cl but it seems like ctx->jitter_transmission_offset is
> always zero?

Indeed it seems so. This has evidently been the case for a long time. OK to fix
that in a separate cl?

[stefan-webrtc, 2015-07-08 09:09:39]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2015-07-08 09:09:39]

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (left):

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:601:
ctx->jitter_transmission_offset);
On 2015/07/08 08:57:59, språng wrote:
> On 2015/06/25 15:14:25, asapersson wrote:
> > Not related to this cl but it seems like ctx->jitter_transmission_offset is
> > always zero?
> 
> Indeed it seems so. This has evidently been the case for a long time. OK to
fix
> that in a separate cl?

I don't think it makes much sense to keep the transmission offset-based jitter.
We never use transmission offsets anyway... :)

[sprang_webrtc, 2015-07-08 09:24:05]

On 2015/07/08 09:09:39, stefan-webrtc (holmer) wrote:
>
https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
> File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (left):
> 
>
https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
> webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:601:
> ctx->jitter_transmission_offset);
> On 2015/07/08 08:57:59, språng wrote:
> > On 2015/06/25 15:14:25, asapersson wrote:
> > > Not related to this cl but it seems like ctx->jitter_transmission_offset
is
> > > always zero?
> > 
> > Indeed it seems so. This has evidently been the case for a long time. OK to
> fix
> > that in a separate cl?
> 
> I don't think it makes much sense to keep the transmission offset-based
jitter.
> We never use transmission offsets anyway... :)

OK, should I change the CL to remove the support for this then? We can keep the
RtcpPacket implementation as a nice-to-have perhaps...

[stefan-webrtc, 2015-07-08 09:30:40]

On 2015/07/08 09:24:05, språng wrote:
> On 2015/07/08 09:09:39, stefan-webrtc (holmer) wrote:
> >
>
https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
> > File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (left):
> > 
> >
>
https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
> > webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:601:
> > ctx->jitter_transmission_offset);
> > On 2015/07/08 08:57:59, språng wrote:
> > > On 2015/06/25 15:14:25, asapersson wrote:
> > > > Not related to this cl but it seems like ctx->jitter_transmission_offset
> is
> > > > always zero?
> > > 
> > > Indeed it seems so. This has evidently been the case for a long time. OK
to
> > fix
> > > that in a separate cl?
> > 
> > I don't think it makes much sense to keep the transmission offset-based
> jitter.
> > We never use transmission offsets anyway... :)
> 
> OK, should I change the CL to remove the support for this then? We can keep
the
> RtcpPacket implementation as a nice-to-have perhaps...

I wouldn't mind at least.

[åsapersson, 2015-07-09 06:55:42]

On 2015/07/08 09:30:40, stefan-webrtc (holmer) wrote:
> On 2015/07/08 09:24:05, språng wrote:
> > On 2015/07/08 09:09:39, stefan-webrtc (holmer) wrote:
> > >
> >
>
https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
> > > File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (left):
> > > 
> > >
> >
>
https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
> > > webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:601:
> > > ctx->jitter_transmission_offset);
> > > On 2015/07/08 08:57:59, språng wrote:
> > > > On 2015/06/25 15:14:25, asapersson wrote:
> > > > > Not related to this cl but it seems like
ctx->jitter_transmission_offset
> > is
> > > > > always zero?
> > > > 
> > > > Indeed it seems so. This has evidently been the case for a long time. OK
> to
> > > fix
> > > > that in a separate cl?
> > > 
> > > I don't think it makes much sense to keep the transmission offset-based
> > jitter.
> > > We never use transmission offsets anyway... :)
> > 
> > OK, should I change the CL to remove the support for this then? We can keep
> the
> > RtcpPacket implementation as a nice-to-have perhaps...
> 
> I wouldn't mind at least.

Sounds good to remove the support.

[åsapersson, 2015-07-22 05:58:27]

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/i...
File webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h (left):

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/i...
webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h:495: 
Also update mock_rtp_rtcp.h.

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc (right):

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc:313:
registered_ssrcs.insert(kMediaSsrc);
The main_ssrc should also be in the set right? And not kMediaSsrc?
Maybe add a constant for 0 (and set rtcp_sender_->SetSSRC).

[sprang_webrtc, 2015-07-23 13:50:40]

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (left):

https://codereview.webrtc.org/1208843003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:601:
ctx->jitter_transmission_offset);
On 2015/07/08 09:09:39, stefan-webrtc (holmer) wrote:
> On 2015/07/08 08:57:59, språng wrote:
> > On 2015/06/25 15:14:25, asapersson wrote:
> > > Not related to this cl but it seems like ctx->jitter_transmission_offset
is
> > > always zero?
> > 
> > Indeed it seems so. This has evidently been the case for a long time. OK to
> fix
> > that in a separate cl?
> 
> I don't think it makes much sense to keep the transmission offset-based
jitter.
> We never use transmission offsets anyway... :)

Acknowledged.

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/i...
File webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h (left):

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/i...
webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h:495: 
On 2015/07/22 05:58:27, asapersson wrote:
> Also update mock_rtp_rtcp.h.

Done.

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc (right):

https://codereview.webrtc.org/1208843003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc:313:
registered_ssrcs.insert(kMediaSsrc);
On 2015/07/22 05:58:27, asapersson wrote:
> The main_ssrc should also be in the set right? And not kMediaSsrc?
> Maybe add a constant for 0 (and set rtcp_sender_->SetSSRC).  

I find these settings a bit confusing. Did I get it right this time?

[åsapersson, 2015-07-23 14:13:00]

lgtm

[åsapersson, 2015-07-23 14:13:01]

lgtm

[sprang_webrtc, 2015-07-24 07:58:34]

Committed patchset #3 (id:40001) manually as
a38233a586dd865c0cd728ce523b3a82ca52ea8b (presubmit successful).