Add flakiness check if there is no received packets in a certain period.

webrtc/p2p/base/p2ptransportchannel_unittest.cc

Index: webrtc/p2p/base/p2ptransportchannel_unittest.cc
diff --git a/webrtc/p2p/base/p2ptransportchannel_unittest.cc b/webrtc/p2p/base/p2ptransportchannel_unittest.cc
index 13f19ae0a54272cb39fb7786162dc761e7277e9a..8213f0d9da3295f862c72b843e1c02ec8aeb6cd2 100644
--- a/webrtc/p2p/base/p2ptransportchannel_unittest.cc
+++ b/webrtc/p2p/base/p2ptransportchannel_unittest.cc
@@ -1861,3 +1861,38 @@ TEST_F(P2PTransportChannelPingTest, ConnectionResurrection) {
   ASSERT_TRUE(conn3 != nullptr);
   EXPECT_EQ(conn3->remote_candidate().priority(), prflx_priority);
 }
+
+TEST_F(P2PTransportChannelPingTest, TestReceivingStateChange) {
+  cricket::FakePortAllocator pa(rtc::Thread::Current(), nullptr);
+  cricket::P2PTransportChannel ch("receiving state change", 1, nullptr, &pa);
+  PrepareChannel(&ch);
+  ch.Connect();
+  ch.OnCandidate(CreateCandidate("1.1.1.1", 1, 1));
+  cricket::Connection* conn1 = WaitForConnectionTo(&ch, "1.1.1.1", 1);
+  ASSERT_TRUE(conn1 != nullptr);
+
+  conn1->ReceivedPing();
+  conn1->OnReadPacket("ABC", 3, rtc::CreatePacketTime(0));
+  EXPECT_TRUE_WAIT(ch.best_connection() != nullptr, 1000)
+  EXPECT_TRUE_WAIT(ch.receiving(), 1000);
+  // The default receiving timeout value is 2500ms.
+  EXPECT_TRUE_WAIT(!ch.receiving(), 4000);
+}
+
+TEST_F(P2PTransportChannelPingTest,
+    TestReceivingStateChangeSetReceivingTimeout) {
+  cricket::FakePortAllocator pa(rtc::Thread::Current(), nullptr);
+  cricket::P2PTransportChannel ch("receiving state change", 1, nullptr, &pa);
+  PrepareChannel(&ch);
+  ch.set_receiving_timeout(500);

[pthatcher1, 2015/07/07 22:01:40]

On second though, just delete the previous test and add this:

EXPECT_GE(1000, ch.receiving_timeout());
EXPECT_GE(200, ch.check_receiving_delay());
ch.set_receiving_timeout(500);
EXPECT_EQ(500, ch.receiving_timeout());
EXPECT_EQ(200, ch.check_receiving_delay());

[honghaiz3, 2015/08/05 23:56:57]

Done.

+  ch.Connect();
+  ch.OnCandidate(CreateCandidate("1.1.1.1", 1, 1));
+  cricket::Connection* conn1 = WaitForConnectionTo(&ch, "1.1.1.1", 1);
+  ASSERT_TRUE(conn1 != nullptr);
+
+  conn1->ReceivedPing();
+  conn1->OnReadPacket("ABC", 3, rtc::CreatePacketTime(0));
+  EXPECT_TRUE_WAIT(ch.best_connection() != nullptr, 1000)
+  EXPECT_TRUE_WAIT(ch.receiving(), 1000);
+  EXPECT_TRUE_WAIT(!ch.receiving(), 1000);
+}