Add flakiness check if there is no received packets in a certain period.

talk/app/webrtc/webrtcsession.cc

Index: talk/app/webrtc/webrtcsession.cc
diff --git a/talk/app/webrtc/webrtcsession.cc b/talk/app/webrtc/webrtcsession.cc
index c0898ff79f3696ddc3ed2b0129503c5ab616bb97..0df5d848d6ba66273c1a09f19ba32e6cd3a4c43d 100644
--- a/talk/app/webrtc/webrtcsession.cc
+++ b/talk/app/webrtc/webrtcsession.cc
@@ -490,6 +490,7 @@ WebRtcSession::WebRtcSession(
       mediastream_signaling_(mediastream_signaling),
       ice_observer_(NULL),
       ice_connection_state_(PeerConnectionInterface::kIceConnectionNew),
+      ice_connection_receiving_(true),
       older_version_remote_peer_(false),
       dtls_enabled_(false),
       data_channel_type_(cricket::DCT_NONE),
@@ -1406,6 +1407,23 @@ void WebRtcSession::OnTransportFailed(cricket::Transport* transport) {
   SetIceConnectionState(PeerConnectionInterface::kIceConnectionFailed);
 }
 
+void WebRtcSession::OnTransportReceiving(cricket::Transport* transport) {
+  ASSERT(signaling_thread()->IsCurrent());
+  if (transport->HasChannels()) {
+    SetIceConnectionReceiving(transport->no_channel_receiving());

[pthatcher1, 2015/07/06 22:04:47]

The session is receiving if no channel is receiving?  Should there be a "!"
somewhere in there?

Also, the logic here is a little more tricky than this.  There are potentially 3
transports: audio, video, and data.  We should probably only be "receiving" if
all transports are receiving.  For example:

int receiving = 0;
int not_receiving = 0;
for (const auto& kv : transport_proxies()) {
  cricket::Transport* transport = kv.second->impl();
  if (transport && transport->HasChannels()) {
    if (transport->no_channel_receiving()) {
      not_receiving++;
    } else {
      receiving++;
    }
  }
}


SetIceConnectionReceiving((receiving > 0) && (not_receiving == 0));

[honghaiz3, 2015/08/05 23:56:57]

Done. Modified as discussed.

+  }
+}
+
+void WebRtcSession::SetIceConnectionReceiving(bool receiving) {
+  if (ice_connection_receiving_ == receiving) {
+    return;
+  }
+  ice_connection_receiving_ = receiving;
+  if (ice_observer_) {
+    ice_observer_->OnIceConnectionReceivingChange(receiving);
+  }
+}
+
 void WebRtcSession::OnTransportProxyCandidatesReady(
     cricket::TransportProxy* proxy, const cricket::Candidates& candidates) {
   ASSERT(signaling_thread()->IsCurrent());