Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: talk/app/webrtc/webrtcsession.h

Issue 1207563002: Add flakiness check if there is no received packets in a certain period. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Address comments except for naming. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/webrtcsession.h
diff --git a/talk/app/webrtc/webrtcsession.h b/talk/app/webrtc/webrtcsession.h
index 2d477e3beba8a7b9a3a78aa1fe3f28b86ae368c0..5d828bc5ce3b931913743286494ce75e4e7f4731 100644
--- a/talk/app/webrtc/webrtcsession.h
+++ b/talk/app/webrtc/webrtcsession.h
@@ -96,6 +96,10 @@ class IceObserver {
// (via PeerConnectionObserver)
virtual void OnIceComplete() {}
+ // Called anytime when all ICE transport channels becomes flaky or
+ // at least one changes back to unflaky.
+ virtual void OnIceFlakinessChange(bool flaky) {}
+
protected:
~IceObserver() {}
@@ -298,6 +302,7 @@ class WebRtcSession : public cricket::BaseSession,
cricket::TransportProxy* proxy,
const cricket::Candidates& candidates);
virtual void OnCandidatesAllocationDone();
+ void OnTransportFlaky(cricket::Transport* transport) override;
pthatcher1 2015/06/26 19:24:02 How about OnTransportReceiving?
honghaiz3 2015/08/05 23:56:56 Done.
// Enables media channels to allow sending of media.
void EnableChannels();
@@ -342,6 +347,7 @@ class WebRtcSession : public cricket::BaseSession,
std::string BadStateErrMsg(State state);
void SetIceConnectionState(PeerConnectionInterface::IceConnectionState state);
+ void SetIceFlaky(bool flaky);
pthatcher1 2015/06/26 19:24:02 How about SetIceConnectionReceiving(bool receiving
honghaiz3 2015/08/05 23:56:56 Done, although not sure if I should just change it
bool ValidateBundleSettings(const cricket::SessionDescription* desc);
bool HasRtcpMuxEnabled(const cricket::ContentInfo* content);
@@ -379,6 +385,7 @@ class WebRtcSession : public cricket::BaseSession,
MediaStreamSignaling* mediastream_signaling_;
IceObserver* ice_observer_;
PeerConnectionInterface::IceConnectionState ice_connection_state_;
+ bool ice_flaky_;
pthatcher1 2015/06/26 19:24:02 How about "bool ice_connection_receiving_"?
honghaiz3 2015/08/05 23:56:56 Done.
rtc::scoped_ptr<SessionDescriptionInterface> local_desc_;
rtc::scoped_ptr<SessionDescriptionInterface> remote_desc_;
// Candidates that arrived before the remote description was set.

Powered by Google App Engine
This is Rietveld 408576698