Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: talk/app/webrtc/peerconnection.h

Issue 1207563002: Add flakiness check if there is no received packets in a certain period. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Address comments except for naming. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/peerconnection.h
diff --git a/talk/app/webrtc/peerconnection.h b/talk/app/webrtc/peerconnection.h
index bea9c2f61b610c83129c01f76af2f8f1080b57d2..8a56caf38f3af75b99dec5e78ae669f4db2e5031 100644
--- a/talk/app/webrtc/peerconnection.h
+++ b/talk/app/webrtc/peerconnection.h
@@ -142,13 +142,14 @@ class PeerConnection : public PeerConnectionInterface,
uint32 ssrc) override;
void OnRemoveLocalVideoTrack(MediaStreamInterface* stream,
VideoTrackInterface* video_track) override;
- virtual void OnRemoveLocalStream(MediaStreamInterface* stream);
+ void OnRemoveLocalStream(MediaStreamInterface* stream) override;
// Implements IceObserver
- virtual void OnIceConnectionChange(IceConnectionState new_state);
- virtual void OnIceGatheringChange(IceGatheringState new_state);
- virtual void OnIceCandidate(const IceCandidateInterface* candidate);
- virtual void OnIceComplete();
+ void OnIceConnectionChange(IceConnectionState new_state) override;
+ void OnIceGatheringChange(IceGatheringState new_state) override;
+ void OnIceCandidate(const IceCandidateInterface* candidate) override;
+ void OnIceComplete() override;
+ void OnIceFlakinessChange(bool flaky) override;
pthatcher1 2015/06/26 19:24:02 How about "OnIceConnectionReceivingChange(bool rec
honghaiz3 2015/08/05 23:56:56 That's a pretty long name. Plus, that may raise mo
// Signals from WebRtcSession.
void OnSessionStateChange(cricket::BaseSession* session,

Powered by Google App Engine
This is Rietveld 408576698