Add flakiness check if there is no received packets in a certain period.

talk/app/webrtc/webrtcsession.cc

 /*
  * libjingle
  * Copyright 2012 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 472 matching lines @@
                            rtc::ToString(rtc::CreateRandomId64() & LLONG_MAX),
                            cricket::NS_JINGLE_RTP,
                            false),
       // RFC 3264: The numeric value of the session id and version in the
       // o line MUST be representable with a "64 bit signed integer".
       // Due to this constraint session id |sid_| is max limited to LLONG_MAX.
       channel_manager_(channel_manager),
       mediastream_signaling_(mediastream_signaling),
       ice_observer_(NULL),
       ice_connection_state_(PeerConnectionInterface::kIceConnectionNew),
+      ice_connection_receiving_(true),
       older_version_remote_peer_(false),
       dtls_enabled_(false),
       data_channel_type_(cricket::DCT_NONE),
       ice_restart_latch_(new IceRestartAnswerLatch),
       metrics_observer_(NULL) {
 }
 
 WebRtcSession::~WebRtcSession() {
   // Destroy video_channel_ first since it may have a pointer to the
   // voice_channel_.
@@ skipping 896 matching lines @@
       ReportNegotiatedCiphers(stats);
     }
   }
 }
 
 void WebRtcSession::OnTransportFailed(cricket::Transport* transport) {
   ASSERT(signaling_thread()->IsCurrent());
   SetIceConnectionState(PeerConnectionInterface::kIceConnectionFailed);
 }
 
+void WebRtcSession::OnTransportReceiving(cricket::Transport* transp) {

[pthatcher1, 2015/07/07 20:49:55]

transp?

[honghaiz3, 2015/08/05 23:56:57]

The parameter is not used and I wanted to avoid the name shadowing, although it
probably does not matter. Change to transport.

+  ASSERT(signaling_thread()->IsCurrent());
+  // The ice connection is considered not_receiving if every transport is
+  // not receiving on any channels.
+  bool not_receiving = true;
+  for (const auto& kv : transport_proxies()) {
+    cricket::Transport* transport = kv.second->impl();
+    if (transport && transport->HasChannels()) {
+      not_receiving &= transport->no_channel_receiving();
+    }
+  }
+  SetIceConnectionReceiving(!not_receiving);

[pthatcher1, 2015/07/07 20:49:55]

Actually, now that I see it, I think it would be more clear in the reverse:

// The ice connection is considered receiving if any
// transport has channels and is receiving.

bool receiving = false;
for (const auto& kv : transport_proxies()) {
  cricket::Transport* transport = kv.second->impl();
  if (transport && transport->HasChannels() &&
!transport->no_channel_receiving()) {
    receiving = true;
    break;
  }
}
SetIceConnectionReceiving(receiving);



Or better yet:

bool receiving = false;
for (const auto& kv : transport_proxies()) {
  cricket::Transport* transport = kv.second->impl();
  if (transport && transport->any_channel_receiving()) {
    receiving = true;
    break;
  }
}
SetIceConnectionReceiving(receiving);

[honghaiz3, 2015/08/05 23:56:57]

Done. This is better. Thanks!

+}
+
+void WebRtcSession::SetIceConnectionReceiving(bool receiving) {
+  if (ice_connection_receiving_ == receiving) {
+    return;
+  }
+  ice_connection_receiving_ = receiving;
+  if (ice_observer_) {
+    ice_observer_->OnIceConnectionReceivingChange(receiving);
+  }
+}
+
 void WebRtcSession::OnTransportProxyCandidatesReady(
     cricket::TransportProxy* proxy, const cricket::Candidates& candidates) {
   ASSERT(signaling_thread()->IsCurrent());
   ProcessNewLocalCandidate(proxy->content_name(), candidates);
 }
 
 void WebRtcSession::OnCandidatesAllocationDone() {
   ASSERT(signaling_thread()->IsCurrent());
   if (ice_observer_) {
     ice_observer_->OnIceGatheringChange(
@@ skipping 514 matching lines @@
 
   if (!srtp_cipher.empty()) {
     metrics_observer_->AddHistogramSample(srtp_name, srtp_cipher);
   }
   if (!ssl_cipher.empty()) {
     metrics_observer_->AddHistogramSample(ssl_name, ssl_cipher);
   }
 }
 
 }  // namespace webrtc