Add flakiness check if there is no received packets in a certain period.

webrtc/p2p/base/dtlstransportchannel.cc

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 100 matching lines @@
   channel_->SignalCandidateReady.connect(this,
       &DtlsTransportChannelWrapper::OnCandidateReady);
   channel_->SignalCandidatesAllocationDone.connect(this,
       &DtlsTransportChannelWrapper::OnCandidatesAllocationDone);
   channel_->SignalRoleConflict.connect(this,
       &DtlsTransportChannelWrapper::OnRoleConflict);
   channel_->SignalRouteChange.connect(this,
       &DtlsTransportChannelWrapper::OnRouteChange);
   channel_->SignalConnectionRemoved.connect(this,
       &DtlsTransportChannelWrapper::OnConnectionRemoved);
+  channel_->SignalFlakyState.connect(this,
+      &DtlsTransportChannelWrapper::OnFlakyState);
 }
 
 DtlsTransportChannelWrapper::~DtlsTransportChannelWrapper() {
 }
 
 void DtlsTransportChannelWrapper::Connect() {
   // We should only get a single call to Connect.
   ASSERT(dtls_state_ == STATE_NONE ||
          dtls_state_ == STATE_OFFERED ||
          dtls_state_ == STATE_ACCEPTED);
@@ skipping 318 matching lines @@
     case STATE_STARTED:
       // Do nothing
       break;
 
     case STATE_CLOSED:
       // Should not happen. Do nothing
       break;
   }
 }
 
+void DtlsTransportChannelWrapper::OnFlakyState(TransportChannel* channel) {
+  ASSERT(rtc::Thread::Current() == worker_thread_);
+  ASSERT(channel == channel_);
+  LOG_J(LS_VERBOSE, this)
+      << "DTLSTransportChannelWrapper: channel flaky state changed to "
+      << channel_->flaky();
+  if (dtls_state_ == STATE_NONE || dtls_state_ == STATE_OPEN) {

[pthatcher1, 2015/06/24 23:42:52]

Why not just always set it, regardless of state?

[honghaiz3, 2015/08/05 23:56:56]

For both set_readable and set_writable, they only do it when the dtls state is
none or open. 
I suppose, if this is in the middle a DTLS exchange, it is better not to fire
the event (which may trigger ICE restart). 

+    // Note: SignalFlakyState fired by set_flaky.
+    set_flaky(channel_->flaky());
+  }
+}
+
 void DtlsTransportChannelWrapper::OnReadPacket(
     TransportChannel* channel, const char* data, size_t size,
     const rtc::PacketTime& packet_time, int flags) {
   ASSERT(rtc::Thread::Current() == worker_thread_);
   ASSERT(channel == channel_);
   ASSERT(flags == 0);
 
   switch (dtls_state_) {
     case STATE_NONE:
       // We are not doing DTLS
@@ skipping 162 matching lines @@
   SignalRouteChange(this, candidate);
 }
 
 void DtlsTransportChannelWrapper::OnConnectionRemoved(
     TransportChannelImpl* channel) {
   ASSERT(channel == channel_);
   SignalConnectionRemoved(this);
 }
 
 }  // namespace cricket