Add flakiness check if there is no received packets in a certain period.

talk/app/webrtc/webrtcsession.cc

 /*
  * libjingle
  * Copyright 2012 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 471 matching lines @@
                            rtc::ToString(rtc::CreateRandomId64() & LLONG_MAX),
                            cricket::NS_JINGLE_RTP,
                            false),
       // RFC 3264: The numeric value of the session id and version in the
       // o line MUST be representable with a "64 bit signed integer".
       // Due to this constraint session id |sid_| is max limited to LLONG_MAX.
       channel_manager_(channel_manager),
       mediastream_signaling_(mediastream_signaling),
       ice_observer_(NULL),
       ice_connection_state_(PeerConnectionInterface::kIceConnectionNew),
+      ice_flaky_(false),

[pthatcher1, 2015/06/24 23:42:52]

Same here: we need a better name than ice_flaky.  

       older_version_remote_peer_(false),
       dtls_enabled_(false),
       data_channel_type_(cricket::DCT_NONE),
       ice_restart_latch_(new IceRestartAnswerLatch),
       metrics_observer_(NULL) {
 }
 
 WebRtcSession::~WebRtcSession() {
   // Destroy video_channel_ first since it may have a pointer to the
   // voice_channel_.
@@ skipping 892 matching lines @@
   if (old_state != PeerConnectionInterface::kIceConnectionCompleted) {
     ReportBestConnectionState(transport);
   }
 }
 
 void WebRtcSession::OnTransportFailed(cricket::Transport* transport) {
   ASSERT(signaling_thread()->IsCurrent());
   SetIceConnectionState(PeerConnectionInterface::kIceConnectionFailed);
 }
 
+void WebRtcSession::OnTransportFlaky(cricket::Transport* transport) {
+  ASSERT(signaling_thread()->IsCurrent());
+  if (transport->HasChannels()) {
+    SetIceFlaky(transport->all_channels_flaky());
+  }
+}
+
+void WebRtcSession::SetIceFlaky(bool flaky) {
+  if (ice_flaky_ != flaky) {

[pthatcher1, 2015/06/24 23:42:52]

Please use an early return.

[honghaiz3, 2015/08/05 23:56:56]

Done.

+    ice_flaky_ = flaky;
+    if (ice_observer_) {
+      ice_observer_->OnIceFlakinessChange(flaky);
+    }
+  }
+}
+
 void WebRtcSession::OnTransportProxyCandidatesReady(
     cricket::TransportProxy* proxy, const cricket::Candidates& candidates) {
   ASSERT(signaling_thread()->IsCurrent());
   ProcessNewLocalCandidate(proxy->content_name(), candidates);
 }
 
 void WebRtcSession::OnCandidatesAllocationDone() {
   ASSERT(signaling_thread()->IsCurrent());
   if (ice_observer_) {
     ice_observer_->OnIceGatheringChange(
@@ skipping 484 matching lines @@
         metrics_observer_->IncrementCounter(kBestConnections_IPv6);
       } else {
         ASSERT(false);
       }
       return;
     }
   }
 }
 
 }  // namespace webrtc