Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1204493002: Set / verify stats report timestamps. (Closed)

Created:
5 years, 6 months ago by joachim
Modified:
5 years, 6 months ago
Reviewers:
hta-webrtc, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set / verify stats report timestamps. This CL updates the track report timestamps which were fixed at "0" before and updates the timestamps in reports for local audio tracks. Also the timestamps are checked in various tests to make sure no "0" is returned. Original CL is at https://webrtc-codereview.appspot.com/51829004/ BUG=webrtc:4316 TBR=hta@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/be24c94c95056e4f0a22039f25f2fa8a27be6b66 Cr-Commit-Position: refs/heads/master@{#9485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 7 chunks +7 lines, -0 lines 0 comments Download
M talk/app/webrtc/statscollector.h View 2 chunks +7 lines, -0 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 5 chunks +27 lines, -6 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 8 chunks +8 lines, -0 lines 0 comments Download
M talk/app/webrtc/test/mockpeerconnectionobservers.h View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204493002/1
5 years, 6 months ago (2015-06-22 21:22:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 22:06:48 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 22:06:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be24c94c95056e4f0a22039f25f2fa8a27be6b66
Cr-Commit-Position: refs/heads/master@{#9485}

Powered by Google App Engine
This is Rietveld 408576698