Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc

Issue 1203803004: Adding a new ChangeLogger class to handle UMA logging of bitrates (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc
diff --git a/webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc b/webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc
index b9d4cdd7d11a3786de4306ff3b91ddef05c246a3..845487e0ab7307651f23aff3775a1fe9a927c976 100644
--- a/webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc
+++ b/webrtc/modules/audio_coding/main/acm2/codec_owner_unittest.cc
@@ -31,7 +31,7 @@ const int kCngPt = 13;
class CodecOwnerTest : public ::testing::Test {
protected:
- CodecOwnerTest() : timestamp_(0) {}
+ CodecOwnerTest() : codec_owner_(nullptr), timestamp_(0) {}
void CreateCodec() {
codec_owner_.SetEncoders(kDefaultCodecInst, kCngPt, VADNormal, -1);
@@ -100,8 +100,6 @@ TEST_F(CodecOwnerTest, VerifyCngFrames) {
TEST_F(CodecOwnerTest, ExternalEncoder) {
MockAudioEncoderMutable external_encoder;
- EXPECT_CALL(external_encoder, GetTargetBitrate())
- .WillRepeatedly(Return(-1)); // Flag adaptive bitrate (doesn't matter).
codec_owner_.SetEncoders(&external_encoder, -1, VADNormal, -1);
const int kSampleRateHz = 8000;
const int kPacketSizeSamples = kSampleRateHz / 100;

Powered by Google App Engine
This is Rietveld 408576698