Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h

Issue 1202253003: More Simulation Framework features (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Comments addressed [4] Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
diff --git a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
index 9fb219d0851caa9e9aec863c11cabc6a3cbad6ab..ef5a02aa8cd825580bd74073b88022dca5c0e75e 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
+++ b/webrtc/modules/remote_bitrate_estimator/test/bwe_test_framework.h
@@ -21,6 +21,7 @@
#include <string>
#include <vector>
+#include "webrtc/base/common.h"
#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
#include "webrtc/modules/interface/module_common_types.h"
@@ -39,10 +40,38 @@ namespace testing {
namespace bwe {
class DelayCapHelper;
-class RateCounter;
+
+class RateCounter {
+ public:
+ RateCounter(int64_t window_size_ms)
+ : window_size_us_(1000 * window_size_ms),
+ recently_received_packets_(0),
+ recently_received_bytes_(0),
+ last_accumulated_us_(0),
+ window_() {}
+
+ RateCounter() : RateCounter(1000) {}
+
+ void UpdateRates(int64_t send_time_us, uint32_t payload_size);
+
+ int64_t window_size_ms() const { return window_size_us_ / 1000; }
+ uint32_t packets_per_second() const;
+ uint32_t bits_per_second() const;
+
+ private:
+ double window_size_s() const;
+ typedef std::pair<int64_t, uint32_t> TimeSizePair;
+
+ int64_t window_size_us_;
+ uint32_t recently_received_packets_;
+ uint32_t recently_received_bytes_;
+ int64_t last_accumulated_us_;
+ std::list<TimeSizePair> window_;
+};
typedef std::set<int> FlowIds;
const FlowIds CreateFlowIds(const int *flow_ids_array, size_t num_flow_ids);
+const FlowIds CreateFlowIdRange(int initial_value, int last_value);
template <typename T>
bool DereferencingComparator(const T* const& a, const T* const& b) {
@@ -149,9 +178,15 @@ class Random {
// Return pseudo random number in the interval [0.0, 1.0].
float Rand();
+ // Return pseudo rounded random number in interval [low, high].
+ int Rand(int low, int high);
+
// Normal Distribution.
int Gaussian(int mean, int standard_deviation);
+ // Exponential Distribution.
+ int Exponential(float lambda);
+
// TODO(solenberg): Random from histogram.
// template<typename T> int Distribution(const std::vector<T> histogram) {
@@ -198,6 +233,12 @@ class PacketProcessor {
const FlowIds& flow_ids() const { return flow_ids_; }
+ uint32_t packets_per_second() const;
+ uint32_t bits_per_second() const;
+
+ protected:
+ RateCounter rate_counter_;
+
private:
PacketProcessorListener* listener_;
const FlowIds flow_ids_;
@@ -213,21 +254,22 @@ class RateCounterFilter : public PacketProcessor {
RateCounterFilter(PacketProcessorListener* listener,
const FlowIds& flow_ids,
const char* name);
+ RateCounterFilter(PacketProcessorListener* listener,
+ const FlowIds& flow_ids,
+ const char* name,
+ int64_t start_plotting_time_ms);
virtual ~RateCounterFilter();
- uint32_t packets_per_second() const;
- uint32_t bits_per_second() const;
-
void LogStats();
Stats<double> GetBitrateStats() const;
virtual void Plot(int64_t timestamp_ms);
virtual void RunFor(int64_t time_ms, Packets* in_out);
private:
- rtc::scoped_ptr<RateCounter> rate_counter_;
Stats<double> packets_per_second_stats_;
Stats<double> kbps_stats_;
std::string name_;
+ int64_t start_plotting_time_ms_;
DISALLOW_IMPLICIT_CONSTRUCTORS(RateCounterFilter);
};
@@ -254,11 +296,11 @@ class DelayFilter : public PacketProcessor {
DelayFilter(PacketProcessorListener* listener, const FlowIds& flow_ids);
virtual ~DelayFilter() {}
- void SetDelayMs(int64_t delay_ms);
+ void SetOneWayDelayMs(int64_t one_way_delay_ms);
virtual void RunFor(int64_t time_ms, Packets* in_out);
private:
- int64_t delay_us_;
+ int64_t one_way_delay_us_;
int64_t last_send_time_us_;
DISALLOW_IMPLICIT_CONSTRUCTORS(DelayFilter);
@@ -305,16 +347,20 @@ class ChokeFilter : public PacketProcessor {
ChokeFilter(PacketProcessorListener* listener, const FlowIds& flow_ids);
virtual ~ChokeFilter();
- void SetCapacity(uint32_t kbps);
- void SetMaxDelay(int max_delay_ms);
+ void set_capacity_kbps(uint32_t kbps);
+ void set_max_delay_ms(int64_t max_queueing_delay_ms);
+
+ uint32_t capacity_kbps();
+
virtual void RunFor(int64_t time_ms, Packets* in_out);
Stats<double> GetDelayStats() const;
private:
- uint32_t kbps_;
+ uint32_t capacity_kbps_;
int64_t last_send_time_us_;
rtc::scoped_ptr<DelayCapHelper> delay_cap_helper_;
+ int64_t max_delay_us_;
DISALLOW_IMPLICIT_CONSTRUCTORS(ChokeFilter);
};
@@ -336,7 +382,7 @@ class TraceBasedDeliveryFilter : public PacketProcessor {
virtual void Plot(int64_t timestamp_ms);
virtual void RunFor(int64_t time_ms, Packets* in_out);
- void SetMaxDelay(int max_delay_ms);
+ void set_max_delay_ms(int64_t max_delay_ms);
Stats<double> GetDelayStats() const;
Stats<double> GetBitrateStats() const;
@@ -390,6 +436,8 @@ class VideoSource {
int64_t next_frame_ms_;
int64_t now_ms_;
RTPHeader prototype_header_;
+ int64_t start_plotting_ms_;
+ uint32_t previous_bitrate_bps_;
DISALLOW_IMPLICIT_CONSTRUCTORS(VideoSource);
};

Powered by Google App Engine
This is Rietveld 408576698