Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1196863003: Send Sdes using RtcpPacket (Closed)

Created:
5 years, 6 months ago by sprang_webrtc
Modified:
5 years, 6 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : CHECK_LT instead of assert #

Total comments: 2

Patch Set 3 : Fixed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -101 lines) Patch
M webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 6 chunks +23 lines, -90 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sprang_webrtc
5 years, 6 months ago (2015-06-22 14:11:53 UTC) #2
åsapersson
https://codereview.webrtc.org/1196863003/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.h File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right): https://codereview.webrtc.org/1196863003/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.h#newcode101 webrtc/modules/rtp_rtcp/source/rtcp_sender.h:101: int32_t AddMixedCNAME(uint32_t SSRC, const char cName[RTCP_CNAME_SIZE]); const char* c_name
5 years, 6 months ago (2015-06-25 10:18:30 UTC) #3
sprang_webrtc
https://codereview.webrtc.org/1196863003/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.h File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right): https://codereview.webrtc.org/1196863003/diff/20001/webrtc/modules/rtp_rtcp/source/rtcp_sender.h#newcode101 webrtc/modules/rtp_rtcp/source/rtcp_sender.h:101: int32_t AddMixedCNAME(uint32_t SSRC, const char cName[RTCP_CNAME_SIZE]); On 2015/06/25 10:18:30, ...
5 years, 6 months ago (2015-06-25 12:30:38 UTC) #4
åsapersson
lgtm
5 years, 6 months ago (2015-06-25 12:41:10 UTC) #5
sprang_webrtc
5 years, 6 months ago (2015-06-25 12:46:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
0ea42d319e2a18785f5de5fe8d52e0a7a5fd1448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698