Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1196623006: Add include_examples GYP variable. (Closed)

Created:
5 years, 6 months ago by kjellander_webrtc
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add include_examples GYP variable. To make it possible to exclude the examples when running GYP on all.gyp. The webrtc_examples.gyp already has an OS=="android" condition inside it, so there's no need to check that before including it. BUG=webrtc:4242 Committed: https://crrev.com/31acf3d1208b294ba86cbcdfa475a5c94229ae3a Cr-Commit-Position: refs/heads/master@{#9556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M all.gyp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kjellander_webrtc
5 years, 6 months ago (2015-06-20 17:28:04 UTC) #2
phoglund_chromium
Andrew, can you review this? We need it for the libjingle import.
5 years, 5 months ago (2015-07-08 13:10:13 UTC) #4
Andrew MacDonald
lgtm Sorry, missed this.
5 years, 5 months ago (2015-07-08 21:39:10 UTC) #5
phoglund
On 2015/07/08 21:39:10, andrew wrote: > lgtm > > Sorry, missed this. No worries at ...
5 years, 5 months ago (2015-07-09 07:33:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196623006/1
5 years, 5 months ago (2015-07-09 07:33:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 08:19:03 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 08:19:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31acf3d1208b294ba86cbcdfa475a5c94229ae3a
Cr-Commit-Position: refs/heads/master@{#9556}

Powered by Google App Engine
This is Rietveld 408576698