Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1196453005: Issue 4780: disabling multiple_routes breaks Turn/Tcp. (Closed)

Created:
5 years, 6 months ago by guoweis_webrtc
Modified:
5 years, 6 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M webrtc/p2p/base/turnport.cc View 1 2 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
guoweis_webrtc
PTAL.
5 years, 6 months ago (2015-06-18 21:15:00 UTC) #2
pthatcher1
https://codereview.webrtc.org/1196453005/diff/1/webrtc/p2p/base/turnport.cc File webrtc/p2p/base/turnport.cc (right): https://codereview.webrtc.org/1196453005/diff/1/webrtc/p2p/base/turnport.cc#newcode339 webrtc/p2p/base/turnport.cc:339: // disabled, the local ip is bound to any ...
5 years, 6 months ago (2015-06-18 21:25:31 UTC) #3
guoweis_webrtc
PTAL https://codereview.webrtc.org/1196453005/diff/1/webrtc/p2p/base/turnport.cc File webrtc/p2p/base/turnport.cc (right): https://codereview.webrtc.org/1196453005/diff/1/webrtc/p2p/base/turnport.cc#newcode339 webrtc/p2p/base/turnport.cc:339: // disabled, the local ip is bound to ...
5 years, 6 months ago (2015-06-19 17:37:50 UTC) #4
pthatcher2
lgtm https://codereview.webrtc.org/1196453005/diff/20001/webrtc/p2p/base/turnport.cc File webrtc/p2p/base/turnport.cc (right): https://codereview.webrtc.org/1196453005/diff/20001/webrtc/p2p/base/turnport.cc#newcode352 webrtc/p2p/base/turnport.cc:352: << ", possibly caused by multiple_routes disabled."; "possibly ...
5 years, 6 months ago (2015-06-19 17:40:27 UTC) #6
guoweis_webrtc
5 years, 6 months ago (2015-06-19 18:27:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7f04b08d3b31c732c66965a09803f6c3e4210a65 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698