Prevent JS from bypassing RTP data channel bandwidth limitation.

Prevent JS from bypassing RTP data channel bandwidth limitation.

Normally the RTP data channel is capped at 30kbps, but by mangling the
SDP string, one could get around this limitation. With this fix,
SdpDeserialize will return an error if it detects this condition.

BUG=280726
R=pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/c0c3a865f49a6386b0815001b9856c1eee27e7c2

[Taylor Brandstetter, 2015-06-24 19:44:06]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2015-06-24 20:01:57]

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp.cc
File talk/app/webrtc/webrtcsdp.cc (right):

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp...
talk/app/webrtc/webrtcsdp.cc:2502: // that would give JS the opportunity to
"break the Internet".
Please reference the bug URL here.

Just say "See $URL".

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp...
talk/app/webrtc/webrtcsdp.cc:2504: b > cricket::kDataMaxBandwidth / 1000) {
&& IsRtp(media_desc->protocol())

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp...
talk/app/webrtc/webrtcsdp.cc:2506: description << "SDP data bandwidth must not
exceed "
A more accurate message would be "RTP-based data channels may not send more than
30kbps".

[Taylor Brandstetter, 2015-06-24 21:41:24]

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp.cc
File talk/app/webrtc/webrtcsdp.cc (right):

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp...
talk/app/webrtc/webrtcsdp.cc:2502: // that would give JS the opportunity to
"break the Internet".
On 2015/06/24 20:01:56, pthatcher1 wrote:
> Please reference the bug URL here.
> 
> Just say "See $URL".

Done.

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp...
talk/app/webrtc/webrtcsdp.cc:2504: b > cricket::kDataMaxBandwidth / 1000) {
On 2015/06/24 20:01:56, pthatcher1 wrote:
> && IsRtp(media_desc->protocol())

Done.

https://codereview.webrtc.org/1196403004/diff/20001/talk/app/webrtc/webrtcsdp...
talk/app/webrtc/webrtcsdp.cc:2506: description << "SDP data bandwidth must not
exceed "
On 2015/06/24 20:01:57, pthatcher1 wrote:
> A more accurate message would be "RTP-based data channels may not send more
than
> 30kbps".

Done.

[pthatcher1, 2015-06-24 21:44:02]

lgtm

[pthatcher1, 2015-06-24 21:44:06]

The CQ bit was checked by pthatcher@webrtc.org

[commit-bot: I haz the power, 2015-06-24 21:44:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1196403004/40001

[commit-bot: I haz the power, 2015-06-24 21:44:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-24 21:44:31]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pthatcher1, 2015-06-24 22:31:42]

Committed patchset #3 (id:40001) manually as
c0c3a865f49a6386b0815001b9856c1eee27e7c2 (presubmit successful).