Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1195963002: Revert "Added ACM_dump protobuf, class for reading/writing and unittest." (Closed)

Created:
5 years, 6 months ago by niklas.enbom
Modified:
5 years, 6 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Added ACM_dump protobuf, class for reading/writing and unittest." This reverts commit e9bdfd859c309991b4ea759587f39eecdbd42bd4. This CL makes the GN chrome bot fail, not really sure why... FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.acm_dump.o.d -DRTC_AUDIOCODING_DEBUG_DUMP -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=239765-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -I../.. -Igen -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64 -march=x86-64 -funwind-tables -fPIC -pipe -pthread -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -Wno-inconsistent-missing-override -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -O2 -fno-ident -fdata-sections -ffunction-sections -g1 -gsplit-dwarf -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.cc -o obj/third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.acm_dump.o ../../third_party/webrtc/modules/audio_coding/main/acm2/acm_dump.cc:11:10: fatal error: 'webrtc/modules/audio_coding/main/acm2/acm_dump.h' file not found #include "webrtc/modules/audio_coding/main/acm2/acm_dump.h" ^ 1 error generated. ninja: build stopped: subcommand failed. TBR=ivoc@webrtc.org BUG= Committed: https://chromium.googlesource.com/external/webrtc/+/7a75415419cbd52d798f9226010e9190e1cbad53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -534 lines) Patch
M DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +0 lines, -25 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_dump.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_dump.cc View 1 chunk +0 lines, -220 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_dump_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module.gypi View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/dump.proto View 1 chunk +0 lines, -78 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
niklas.enbom
5 years, 6 months ago (2015-06-19 21:29:41 UTC) #2
niklas.enbom
5 years, 6 months ago (2015-06-19 21:30:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a75415419cbd52d798f9226010e9190e1cbad53.

Powered by Google App Engine
This is Rietveld 408576698