webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h - Issue 1194773002: Re-enable WebRtcIsacfix_AllpassFilter2FixDec16Neon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h

Issue 1194773002: Re-enable WebRtcIsacfix_AllpassFilter2FixDec16Neon (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/BUILD.gn ('k') | webrtc/modules/audio_coding/codecs/isac/fix/source/filterbanks_unittest.cc » ('j') | webrtc/modules/audio_coding/codecs/isac/isacfix.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h

diff --git a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h

index d6153e09fcad61288a292cb278a5c638549c27e6..0e67e300ac138aabf5d17115cc4302e6dcd2a38f 100644

--- a/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h

+++ b/webrtc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h

@@ -60,10 +60,6 @@ void WebRtcIsacfix_AllpassFilter2FixDec16C(

int32_t *filter_state_ch1,

int32_t *filter_state_ch2);

-// Disable AllpassFilter2FixDec16Neon function due to a clang bug.

-// Refer more details at:

-// https://code.google.com/p/webrtc/issues/detail?id=4567

-#if !defined(__clang__) || !defined(WEBRTC_ARCH_ARM64)

#if (defined WEBRTC_DETECT_NEON) || (defined WEBRTC_HAS_NEON)

void WebRtcIsacfix_AllpassFilter2FixDec16Neon(

int16_t *data_ch1,

@@ -74,7 +70,6 @@ void WebRtcIsacfix_AllpassFilter2FixDec16Neon(

int32_t *filter_state_ch1,

int32_t *filter_state_ch2);

#endif

-#endif

#if defined(MIPS_DSP_R1_LE)

void WebRtcIsacfix_AllpassFilter2FixDec16MIPS(