Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1194533002: Add temporal-layers option to video_loopback. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add temporal-layers option to video_loopback. BUG= R=asapersson@webrtc.org, sprang@webrtc.org Committed: https://crrev.com/9874ee0d7a3c2ae6000ae6e82ae9087986b0469e Cr-Commit-Position: refs/heads/master@{#9482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M webrtc/video/loopback.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/loopback.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_loopback.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
pbos-webrtc
PTAL, asapersson@ for the feature and sprang@ to verify that I didn't destroy screenshare loopback.
5 years, 6 months ago (2015-06-17 09:48:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194533002/1
5 years, 6 months ago (2015-06-17 09:48:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 11:00:07 UTC) #5
åsapersson
On 2015/06/17 11:00:07, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 6 months ago (2015-06-22 09:19:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194533002/1
5 years, 6 months ago (2015-06-22 09:36:02 UTC) #8
pbos-webrtc
On 2015/06/22 09:36:02, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 6 months ago (2015-06-22 09:39:24 UTC) #10
sprang_webrtc
lgtm
5 years, 6 months ago (2015-06-22 11:41:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194533002/1
5 years, 6 months ago (2015-06-22 11:43:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 11:44:30 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 11:44:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9874ee0d7a3c2ae6000ae6e82ae9087986b0469e
Cr-Commit-Position: refs/heads/master@{#9482}

Powered by Google App Engine
This is Rietveld 408576698