Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1193883006: Adding an equals method for KeyValuePair for easier testing. (Closed)

Created:
5 years, 6 months ago by phoglund
Modified:
5 years, 6 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding an equals method for KeyValuePair for easier testing. With this we can write stuff like assertThat(result.mandatory, hasItem(new KeyValuePair("minWidth", "1280"))); The above will currently fail because the object falls back to ==. BUG=None Committed: https://crrev.com/7ab5f801dd8d6bc018b59d41877f44ec4ab19d15 Cr-Commit-Position: refs/heads/master@{#9494}

Patch Set 1 #

Patch Set 2 : adding hashCode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M talk/app/webrtc/java/src/org/webrtc/MediaConstraints.java View 1 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund
5 years, 6 months ago (2015-06-23 15:46:03 UTC) #2
AlexG
lgtm
5 years, 6 months ago (2015-06-23 20:22:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193883006/20001
5 years, 6 months ago (2015-06-24 07:34:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 08:11:52 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 08:12:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ab5f801dd8d6bc018b59d41877f44ec4ab19d15
Cr-Commit-Position: refs/heads/master@{#9494}

Powered by Google App Engine
This is Rietveld 408576698