webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc - Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc ('k') | webrtc/modules/video_coding/codecs/vp8/simulcast_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

index 280296c7b158be05642e8b395c400fe3c827296e..ee7fd859b5380b5078779e451bc46e27b8eb89dd 100644

--- a/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc

@@ -102,10 +102,7 @@ struct ScreenshareTemporalLayersFactory : webrtc::TemporalLayers::Factory {

virtual webrtc::TemporalLayers* Create(int num_temporal_layers,

uint8_t initial_tl0_pic_idx) const {

- return new webrtc::ScreenshareLayers(num_temporal_layers,

- rand(),

- &tl0_frame_dropper_,

- &tl1_frame_dropper_);

+ return new webrtc::ScreenshareLayers(num_temporal_layers, rand());

}

mutable webrtc::FrameDropper tl0_frame_dropper_;