webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc - Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc

Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/default_temporal_layers.h ('k') | webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc b/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc

index f16c7568137d539068d354e6d53d3a520276a33d..15b5af92002de7f04ba586893822ba9f4e9680f7 100644

--- a/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/realtime_temporal_layers.cc

@@ -239,7 +239,9 @@ class RealTimeTemporalLayers : public TemporalLayers {

}

- void FrameEncoded(unsigned int size, uint32_t timestamp) {}

+ void FrameEncoded(unsigned int size, uint32_t timestamp, int qp) override {}

+ bool UpdateConfiguration(vpx_codec_enc_cfg_t* cfg) override { return false; }

private:

int temporal_layers_;