talk/media/webrtc/webrtcvideoengine2_unittest.cc - Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvideoengine2_unittest.cc

Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/media/webrtc/webrtcvideoengine2_unittest.cc

diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.cc b/talk/media/webrtc/webrtcvideoengine2_unittest.cc

index d83e8c4b9c89f6fd17f1054cde3fe7917492dbce..230ca3b2b06af48f51cbecdb28d4a1c4fc7b00de 100644

--- a/talk/media/webrtc/webrtcvideoengine2_unittest.cc

+++ b/talk/media/webrtc/webrtcvideoengine2_unittest.cc

@@ -1438,7 +1438,8 @@ TEST_F(WebRtcVideoChannel2Test, UsesCorrectSettingsForScreencast) {

TEST_F(WebRtcVideoChannel2Test,

ConferenceModeScreencastConfiguresTemporalLayer) {

- static const int kConferenceScreencastTemporalBitrateBps = 100000;

+ static const int kConferenceScreencastTemporalBitrateBps =

+ ScreenshareLayerConfig::GetDefault().tl0_bitrate_kbps * 1000;

VideoOptions options;

options.conference_mode.Set(true);

channel_->SetOptions(options);

« no previous file with comments | « talk/media/webrtc/simulcast.cc ('k') | webrtc/modules/video_coding/codecs/interface/video_error_codes.h » ('j') | no next file with comments »