Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc

Issue 1193513006: In screenshare mode, suppress VP8 bitrate overshoot and increase quality (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
diff --git a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
index e12f9ce0884b227717481fc0d74bee4b2aa5579f..3bf62b673143093a93c82888c9882fb889f73bbb 100644
--- a/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc
@@ -39,10 +39,7 @@ class ScreenshareLayersFT : public ScreenshareLayers {
uint8_t initial_tl0_pic_idx,
FrameDropper* tl0_frame_dropper,
FrameDropper* tl1_frame_dropper)
- : ScreenshareLayers(num_temporal_layers,
- initial_tl0_pic_idx,
- tl0_frame_dropper,
- tl1_frame_dropper) {}
+ : ScreenshareLayers(num_temporal_layers, initial_tl0_pic_idx) {}
virtual ~ScreenshareLayersFT() {}
};
@@ -85,7 +82,7 @@ class ScreenshareLayerTest : public ::testing::Test {
int* flags) {
*flags = layers_->EncodeFlags(timestamp);
layers_->PopulateCodecSpecific(base_sync, vp8_info, timestamp);
- layers_->FrameEncoded(kFrameSize, timestamp);
+ layers_->FrameEncoded(kFrameSize, timestamp, -1);
}
NiceMock<MockFrameDropper> tl0_frame_dropper_;
@@ -112,7 +109,7 @@ TEST_F(ScreenshareLayerTest, 1Layer) {
EXPECT_EQ(static_cast<uint8_t>(kNoTemporalIdx), vp8_info.temporalIdx);
EXPECT_FALSE(vp8_info.layerSync);
EXPECT_EQ(kNoTl0PicIdx, vp8_info.tl0PicIdx);
- layers_->FrameEncoded(kFrameSize, timestamp);
+ layers_->FrameEncoded(kFrameSize, timestamp, -1);
EXPECT_CALL(tl0_frame_dropper_, DropFrame())
.Times(0);
@@ -125,7 +122,7 @@ TEST_F(ScreenshareLayerTest, 1Layer) {
EXPECT_EQ(static_cast<uint8_t>(kNoTemporalIdx), vp8_info.temporalIdx);
EXPECT_FALSE(vp8_info.layerSync);
EXPECT_EQ(kNoTl0PicIdx, vp8_info.tl0PicIdx);
- layers_->FrameEncoded(kFrameSize, timestamp);
+ layers_->FrameEncoded(kFrameSize, timestamp, -1);
}
TEST_F(ScreenshareLayerTest, 2Layer) {

Powered by Google App Engine
This is Rietveld 408576698